Skip to content

syncLang.py: link in markdown output#3179

Merged
koppor merged 1 commit into
JabRef:masterfrom
mlep:patch-56
Sep 1, 2017
Merged

syncLang.py: link in markdown output#3179
koppor merged 1 commit into
JabRef:masterfrom
mlep:patch-56

Conversation

@mlep

@mlep mlep commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

To allow for a more direct edit of the localization files.

Please, triple check, I am in no way a python programmer.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, have not yet tried it

@koppor

koppor commented Sep 1, 2017

Copy link
Copy Markdown
Member

Tried id out locally - and it works. Thank you for the PR!

@koppor koppor merged commit 9ffcb69 into JabRef:master Sep 1, 2017
@LinusDietz

Copy link
Copy Markdown
Member

as a follow up: I have tested it as well, works.

What about automatically generating this data with each push to master and publish a html version on jabref.org?

@mlep

mlep commented Sep 1, 2017

Copy link
Copy Markdown
Contributor Author

It would be nice!

@mlep

mlep commented Sep 1, 2017

Copy link
Copy Markdown
Contributor Author

Although: it would be nice if the order of the languages would be always the same.

@LinusDietz

Copy link
Copy Markdown
Member

That should be feasible. Is that all the requirements you can think of? I would volunteer to program that. Would you be so kind to file an issue to separate the discussion and point out all potential requirements?

@mlep mlep mentioned this pull request Sep 1, 2017
@mlep

mlep commented Sep 1, 2017

Copy link
Copy Markdown
Contributor Author

Done (Issue #3181)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants