Skip to content

Update source tab when an entry is changed#3019

Merged
Siedlerchr merged 3 commits into
masterfrom
fix-source-editor-update
Jul 18, 2017
Merged

Update source tab when an entry is changed#3019
Siedlerchr merged 3 commits into
masterfrom
fix-source-editor-update

Conversation

@lenhard

@lenhard lenhard commented Jul 17, 2017

Copy link
Copy Markdown
Member

Attempts to fix the remaining part of #2888. The source tab is now updated each time an entry is changed in the editor.

There no part of a BibEntry that represents the source tab per se to which we could bind. Therefore, this PR adds a listener to the source tab. It now listens to EntryChangedEvents and if the entry that it represents is changed, then it updates its content.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 17, 2017
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 18, 2017
@Siedlerchr Siedlerchr merged commit 3028d47 into master Jul 18, 2017
@koppor koppor deleted the fix-source-editor-update branch July 18, 2017 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants