Show pdf comments#2545
Merged
Merged
Conversation
# Conflicts: # src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java
# Conflicts: # CHANGELOG.md # src/databaseTest/java/net/sf/jabref/shared/DBMSSynchronizerTest.java # src/databaseTest/java/net/sf/jabref/shared/SynchronizationTestSimulator.java # src/jmh/java/net/sf/jabref/benchmarks/Benchmarks.java # src/main/java/net/sf/jabref/BibDatabaseContext.java # src/main/java/net/sf/jabref/gui/BasePanel.java # src/main/java/net/sf/jabref/gui/DuplicateResolverDialog.java # src/main/java/net/sf/jabref/gui/JabRefFrame.java # src/main/java/net/sf/jabref/gui/StringDialog.java # src/main/java/net/sf/jabref/gui/actions/BrowseAction.java # src/main/java/net/sf/jabref/gui/bibtexkeypattern/BibtexKeyPatternDialog.java # src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java # src/main/java/net/sf/jabref/gui/entryeditor/PdfCommentsTab.java # src/main/java/net/sf/jabref/gui/importer/ImportFileFilter.java # src/main/java/net/sf/jabref/gui/importer/actions/AppendDatabaseAction.java # src/main/java/net/sf/jabref/gui/maintable/MainTable.java # src/main/java/net/sf/jabref/gui/maintable/MainTableColumn.java # src/main/java/net/sf/jabref/gui/mergeentries/MergeFetchedEntryDialog.java # src/main/java/net/sf/jabref/gui/openoffice/StyleSelectDialog.java # src/main/java/net/sf/jabref/gui/preftabs/PreferencesDialog.java # src/main/java/net/sf/jabref/gui/protectedterms/ProtectedTermsDialog.java # src/main/java/net/sf/jabref/gui/shared/OpenSharedDatabaseDialog.java # src/main/java/net/sf/jabref/gui/shared/SharedDatabaseUIManager.java # src/main/java/net/sf/jabref/gui/util/PositionWindow.java # src/main/java/net/sf/jabref/logic/auxparser/AuxParser.java # src/main/java/net/sf/jabref/logic/bibtexkeypattern/BibtexKeyPatternPreferences.java # src/main/java/net/sf/jabref/logic/bibtexkeypattern/BibtexKeyPatternUtil.java # src/main/java/net/sf/jabref/logic/importer/fileformat/BibtexParser.java # src/main/java/net/sf/jabref/logic/importer/fileformat/PdfContentImporter.java # src/main/java/net/sf/jabref/logic/msbib/BibTeXConverter.java # src/main/java/net/sf/jabref/logic/msbib/MSBibDatabase.java # src/main/java/net/sf/jabref/logic/msbib/MSBibEntry.java # src/main/java/net/sf/jabref/logic/pdf/PdfCommentImporter.java # src/main/java/net/sf/jabref/logic/util/io/RegExpFileSearch.java # src/main/java/net/sf/jabref/logic/xmp/XMPSchemaBibtex.java # src/main/java/net/sf/jabref/model/database/BibDatabase.java # src/main/java/net/sf/jabref/model/entry/BibEntry.java # src/main/java/net/sf/jabref/pdfimport/PdfImporter.java # src/main/java/net/sf/jabref/preferences/JabRefPreferences.java # src/main/java/net/sf/jabref/shared/DBMSProcessor.java # src/main/java/net/sf/jabref/shared/DBMSSynchronizer.java # src/test/java/net/sf/jabref/BibDatabaseContextTest.java # src/test/java/net/sf/jabref/gui/importer/actions/ConvertLegacyExplicitGroupsTest.java # src/test/java/net/sf/jabref/logic/auxparser/AuxParserTest.java # src/test/java/net/sf/jabref/logic/bibtexkeypattern/BibtexKeyPatternUtilTest.java # src/test/java/net/sf/jabref/logic/exporter/BibtexDatabaseWriterTest.java # src/test/java/net/sf/jabref/logic/groups/ExplicitGroupTest.java # src/test/java/net/sf/jabref/logic/groups/GroupTreeNodeTest.java # src/test/java/net/sf/jabref/logic/groups/KeywordGroupTest.java # src/test/java/net/sf/jabref/logic/importer/fileformat/BibtexParserTest.java # src/test/java/net/sf/jabref/logic/integrity/EntryLinkCheckerTest.java # src/test/java/net/sf/jabref/model/database/KeyChangeListenerTest.java # src/test/resources/net/sf/jabref/logic/exporter/MsBibExportFormatTest2.xml
# Conflicts: # build.gradle # src/main/java/net/sf/jabref/gui/BasePanel.java # src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java # src/main/java/net/sf/jabref/preferences/JabRefPreferences.java
This was referenced Feb 15, 2017
simonharrer
reviewed
Feb 15, 2017
| import net.sf.jabref.model.entry.BibEntry; | ||
| import net.sf.jabref.model.pdf.FileAnnotation; | ||
|
|
||
| import org.apache.commons.collections4.map.LRUMap; |
Contributor
There was a problem hiding this comment.
Could we use a class from google guava instead? Because of this LRUMap class, the whole commons collections library has to be included.
# Conflicts: # CHANGELOG.md # src/main/java/net/sf/jabref/gui/entryeditor/EntryEditor.java
|
@lenhard is this really hard to implement? #662. It would be really helpful to open the annotation on the PDF location. JabRef could store the page number/label of the annotation and the user could configure its preferred PDF reader as: This solves the arbitrary combinations of operating systems and pdf readers, no? |
Member
Author
|
@kafran It is all relative of course ;-) Storing the page number/ label of the annotation is already done right now, I guess. What makes this a lot of effort is if we want offer built-in configurations for a number of pdf readers and operating system (since we would have to test that). I guess if we just offer the user to execute a command he has to configure himself, it would get easier. We would still get support requests from people asking how things should work for their particular configuration, though. Anyway, I guess this could be done. I don't see anyone from the current developers volunteering right now (@jabref/developers feel free to disagree), but you are very welcome to go ahead with an implementation and to provide a pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1883 which I cannot modify because I have no commit access to that branch.
I tested the features under Windows and it works fine overall. Opening the PDF at the position of the annotation does not work for me, hence I removed the button that provided this functionality. At this time (four month of inactivity in the other PR), the only point is to get the functionality in that actually works.