Fix #2279: File permissions are kept upon save#2281
Conversation
|
Good job! Give it some time. If there is no build tomorrow, try restarting. Then @g-mos should give it a try and see if it keeps permissions. |
|
I would be happy to test whatever is needed. Since I am new to this, inform me and tell me, when and what I need to download. |
|
@tobiasdiez Could you create a branch at the JabRef main repo?
|
|
@koppor I pushed to a branch in the main rep (https://github.com/JabRef/jabref/tree/filePermissions) but no build appears under http://builds.jabref.org/. |
|
A test failed at circleCI... I've restarted the build: https://circleci.com/gh/JabRef/jabref/8328 |
|
Thanks @matthiasgeiger, it worked! @g-mos could you please install the development version from http://builds.jabref.org/filePermissions/ and test if the permission issue is indeed resolved. Thank you! |
|
LGTM 👍 |
|
I can confirm that the permissions of the files are kept. Therefore the issue at hand is fixed. |
| Here, the categories "Changed" for added and changed functionality, | ||
| "Fixed" for fixed functionality, and | ||
| "Removed" for removed functionality is used. | ||
| "Removed" for removed functionality are used. |
There was a problem hiding this comment.
Why "are"?
Functionality is singular
Either you let the is or you use functionalities
There was a problem hiding this comment.
the object is "categories" which is plural.
Siedlerchr
left a comment
There was a problem hiding this comment.
LGTM for the moment I think we can merge it in.
We should think about/creating a new PR for checking if the copy is really necessary
|
@g-mos Thanks for your feedback (and reporting the issue in the first place). |
|
@tobiasdiez I agree for the security layer. My idea is |
|
@g-mos Due to a problem on windows I slightly had to change the code. Follow up is in #2286 |
|
Unfortunately @Siedlerchr, this new version returns to the original problem. The permissions are completely destroyed. rw for user and no access to everybody else. It is also changing of user/group ownership to the user that shaved the jabref file. Sorry for the bad news. |
|
@g-mos Okay, thanks for the feedback. I will investigate this further. In the meantime you can revert back to the version before. |
Fixes #2279.
JabRef does not directly writes to the bib-file upon save but creates a temporary file which is then copied over the original one. In this process the original file permissions get lost. Should be fixed with this PR (I have not tried it...).
I pushed the code to the branch https://github.com/JabRef/jabref/tree/filePermissions but for some reason the setup files do not show up on builds.jabref.org
gradle localizationUpdate?