Skip to content

Cleanup and format some files#166

Closed
tobiasdiez wants to merge 4 commits into
JabRef:masterfrom
tobiasdiez:master
Closed

Cleanup and format some files#166
tobiasdiez wants to merge 4 commits into
JabRef:masterfrom
tobiasdiez:master

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

Run cleanup and format in eclipse on some files to make comparison in #162 easier.

@koppor

koppor commented Sep 17, 2015

Copy link
Copy Markdown
Member

Regarding the private final AbstractAction toggleGroups = new GeneralAction statements (see my second comment), you don't agree?

@matthiasgeiger

Copy link
Copy Markdown
Member

@koppor I agree. But I think, this behavior was introduced by a change you made in 77d1ea8 - using this setting IntelliJ creates endless lines using auto-format.

@tobiasdiez

Copy link
Copy Markdown
Member Author

I don't have a strong opinion about this. Sometimes it is more important to see what variables exists (then the new formatting is better) and sometimes you are more interested in how the initialization is done (then the old formatting is better). So should I revert this too?

@koppor

koppor commented Sep 17, 2015

Copy link
Copy Markdown
Member

Yeah. I thought, I did run the gradle formatter plugin, but it seems, it didn't touch that file somehow :(

@tobiasdiez Could you revert and add @Formatter:on/off strings? I prefer to see the initialization code 😇 That would really help!

@simonharrer

Copy link
Copy Markdown
Contributor

What is the current state of the eclipse xml @koppor @matthiasgeiger

@matthiasgeiger

Copy link
Copy Markdown
Member

Updated after discussion with @koppor in 0fd8a0c

@koppor

koppor commented Oct 20, 2015

Copy link
Copy Markdown
Member

As new formatter rules are in place, we should close this and follow up at #249.

@matthiasgeiger

Copy link
Copy Markdown
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants