Feat/hayagriva yaml importer(#15714)#15738
Conversation
|
Please disclose AI usage in the PR description. |
|
PR description and steps to test are suspected to be generated by AI. At least please disclose AI usage and attach screenshots in steps to test. Otherwise your PR will not be reviewed. |
|
Your pull request conflicts with the target branch. Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line. |
| /// Returns the string value from a Hayagriva title or url field. | ||
| /// The field can be a plain string or a map containing a {@code value} key. | ||
| @Nullable | ||
| private static String extractStringValue(@Nullable Object field) { |
| @JsonProperty("issue") | ||
| String issue; | ||
|
|
||
| @JsonProperty("publisher") |
There was a problem hiding this comment.
Why repeated annotations?
Please make it an outter class. - Maybe "DTO" - see jabsrv
|
|
||
| // POJO classes for YAML deserialization | ||
|
|
||
| private static class HayagrivaEntry { |
| BibEntry entry = new BibEntry(entryType); | ||
| entry.setCitationKey(citationKey); | ||
| entry.setField(fields); |
|
Closing this issue due to inactivity 💤 |
|
This pull requests was closed without merging. You have been unassigned from the respective issue #15714. In case you closed the PR for yourself, you can re-open it. Please also check After submission of a pull request in CONTRIBUTING.md. |
Related issues and pull requests
Closes #15714
PR Description
Added support for importing Hayagriva YAML files into JabRef by implementing a new importer in the fileformat package, adding it to the list of importers JabRef checks when opening a file and writing tests using both custom test files and the official basic.yml from the upstream Hayagriva test guide. Hayagriva is the citation format JabRef could already export to it, but had no way to read it back in.
The round-trip test (export → import → compare) covering all serial-number subtypes (DOI, ISBN, ISSN, …) cannot be added yet as it is blocked by #15713, which needs to be fixed first. It will be added as a follow-up once that issue is resolved.
Steps to test
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)