Cite multiple entries as a single citation for CSL in-text by pluto-han · Pull Request #15706 · JabRef/jabref

pluto-han · 2026-05-08T09:28:08Z

Related issues and pull requests

PR Description

When insert multiple references at once using CSL in-text, entries are seperated into multiple reference marks instead of one single reference mark.

This PR adds a createInTextCitationGroupText method to create a single in-text citation.

Steps to test

Open JabRef and a LibreOffice Writer document
Open Chocolate.bib in JabRef
Connect to the running LO instance
Select any CSL style
Select multiple entries and press in-text cite

Observe they are cited as a single reference mark.

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
[/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
[/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

qodo-free-for-open-source-projects · 2026-05-08T09:28:29Z

Review Summary by Qodo

Consolidate multiple CSL in-text citations into single mark

🐞 Bug fix

Walkthroughs

Description

• Consolidate multiple CSL in-text citations into single reference mark
• Extract citation grouping logic into reusable helper method
• Apply grouping to both insertion and style update operations

Diagram

flowchart LR
  A["Multiple BibEntries"] -->|"createInTextCitationGroupText"| B["Single Citation String"]
  B -->|"insertReferences"| C["Single Reference Mark"]
  D["Update Style"] -->|"createInTextCitationGroupText"| B

File Changes

1. jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java 🐞 Bug fix +16/-33

Implement grouped in-text citation generation

• Replaced loop-based citation insertion with new createInTextCitationGroupText helper method
• Simplified insertInTextCitation to create single grouped citation instead of multiple separate
 ones
• Refactored updateAllCitationsWithNewStyle to use the new helper method for consistent grouping
• Added StringJoiner import for cleaner citation concatenation

jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java

2. CHANGELOG.md 📝 Documentation +1/-0

Document CSL in-text citation grouping fix
• Added entry documenting the fix for issue #15703 regarding multiple CSL in-text citations
CHANGELOG.md

qodo-free-for-open-source-projects · 2026-05-08T09:28:30Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1)

1. No tests for citation grouping 📘 Rule violation ☼ Reliability

Description

This PR changes in-text citation generation behavior by introducing grouped citation text, but no
corresponding tests were added/updated to cover the new behavior. This increases regression risk for
CSL in-text citation formatting and mark insertion/update flows.

Code

jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java[R139-141]

+        String citation = createInTextCitationGroupText(selectedStyle, isAlphanumericStyle, isNumericStyle, entries, bibDatabaseContext);
+        OOText ooText = OOFormat.setLocaleNone(OOText.fromString(citation));
+        insertReferences(cursor, entries, ooText, isNumericStyle, CSLCitationType.IN_TEXT);

Evidence
PR Compliance ID 16 requires tests to be added/updated for behavior changes in logic code. The diff
shows a behavioral change to generate a single grouped in-text citation string via
createInTextCitationGroupText(...) and insert/update references using the grouped text, but the PR
diff contains no test changes covering this new grouping behavior.
AGENTS.md
jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java[139-141]
jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java[323-331]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR changes CSL in-text citation behavior to emit a single grouped citation string, but no tests were added/updated to verify the new behavior.

## Issue Context
`insertInTextCitation(...)` and the IN_TEXT update flow now depend on `createInTextCitationGroupText(...)` to join multiple entry citations into one mark/text.

## Fix Focus Areas
- jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java[139-141]
- jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java[323-331]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Siedlerchr · 2026-05-08T21:31:32Z

Definitely an improvement!

Siedlerchr

That should already generate a combined citaiton

subhramit · 2026-05-08T22:23:13Z

            String prefix = CSLFormatUtils.generateAuthorPrefix(currentEntry, bibDatabaseContext);
            citation = prefix + citation;
        } else if (!isAlphaNumericStyle) {
            citation = CSLFormatUtils.changeToInText(citation);


Possible future exploration for @pluto-han following from @Siedlerchr's comment
I think downstream of this function we are using JabRef's style of extracting authors and joining with the numeric part to convert to in-text.

See if that can be replaced by using citeproc's native authorOnly and suppressAuthor. See examples here.
This can help us add more methods in CitationStyleGenerator. We may be able to make our own generateInTextCitation like generateCitation and generateBibliography there.

See if that can be replaced by using citeproc's native authorOnly and suppressAuthor. See examples here.

Yep good idea. Should i implement it in this PR or in a seperate one?

Let that be separate. Let's solve one thing at a time, as incremental changes are easier to review and track. Feel free to open a tracking issue for this refactoring, though.

subhramit · 2026-05-11T21:18:43Z


+    /// Helper method for creating citation group for `insertInTextCitation` and `updateAllCitationsWithNewStyle`
+    private @NonNull String createInTextCitationGroupText(CitationStyle style, boolean isAlphaNumericStyle, boolean isNumericStyle, List<BibEntry> entries, BibDatabaseContext bibDatabaseContext) {
+        StringJoiner citations = new StringJoiner(", ");


Follow-up: aptly named constant

pluto-han added 3 commits May 8, 2026 11:00

Implement group citation for CSL in-text

4c8cfeb

Add comments

f1b068e

Update changelog

ac5678c

github-actions Bot added the component: libre-office label May 8, 2026

github-actions Bot mentioned this pull request May 8, 2026

Multiple entries are not cited as a single reference mark for CSL in-text #15703

Closed

github-actions Bot added the status: no-bot-comments label May 8, 2026

subhramit added project: gsoc labels May 8, 2026

pluto-han mentioned this pull request May 8, 2026

Missing space for multiple entry citation for CSL normal #15704

Closed

Siedlerchr approved these changes May 8, 2026

View reviewed changes

Siedlerchr requested changes May 8, 2026

View reviewed changes

Comment thread jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: no-bot-comments labels May 8, 2026

subhramit requested a review from koppor May 8, 2026 22:07

subhramit reviewed May 8, 2026

View reviewed changes

Siedlerchr approved these changes May 11, 2026

View reviewed changes

Siedlerchr added this pull request to the merge queue May 11, 2026

github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label May 11, 2026

Merged via the queue into JabRef:main with commit ca0f6b4 May 11, 2026
121 of 130 checks passed

subhramit approved these changes May 11, 2026

View reviewed changes

pluto-han mentioned this pull request May 14, 2026

Extract magic string to constant #15735

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cite multiple entries as a single citation for CSL in-text#15706

Cite multiple entries as a single citation for CSL in-text#15706
Siedlerchr merged 3 commits into
JabRef:mainfrom
pluto-han:fix-for-15703

pluto-han commented May 8, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot commented May 8, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented May 8, 2026 •

edited

Loading

Uh oh!

Siedlerchr commented May 8, 2026

Uh oh!

Siedlerchr left a comment

Uh oh!

Uh oh!

subhramit May 8, 2026 •

edited

Loading

Uh oh!

pluto-han May 9, 2026

Uh oh!

subhramit May 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

subhramit May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pluto-han commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

qodo-free-for-open-source-projects Bot commented May 8, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Siedlerchr commented May 8, 2026

Uh oh!

Siedlerchr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

subhramit May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pluto-han May 9, 2026

Choose a reason for hiding this comment

Uh oh!

subhramit May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

subhramit May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pluto-han commented May 8, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented May 8, 2026 •

edited

Loading

subhramit May 8, 2026 •

edited

Loading

subhramit May 9, 2026 •

edited

Loading