Updated FileKeystore field not disabled when SSL Property is not enabled by gandhroh000 · Pull Request #15661 · JabRef/jabref

gandhroh000 · 2026-05-03T01:16:01Z

Related issues and pull requests

PR Description

In the "Connect to Shared Database" page, when the "Use SSL" checkbox was deselected, fileKeyStore would still be showing as a required field, which can be confusing to the user. For reference, only when the SSL connection checkbox is enabled, the fileKeyStore field would be enabled. To change this, it was necessary to add a condition to the SharedDatabaseLoginDialogView. java file that triggered the disabledProperty function, hiding the fileKeyStore entry field.

Steps to test

Open a local copy of this version which has the UI change implemented
Once the JabRef application is open, select the File button in the upper left hand corner
Once the dropdown menu has expanded, click on the "Connect to shared database"
Once the Shared Database Page has opened, attempt to click the the SSL connection checkbox
Clicking the "Use SSL" checkbox (check box is filled with a checkmark and green color) will visually change the color of the fields (KeyStore, Browse Button, and KeyStore password) to a brighter color.
When the "Use SSL" checkbox is enabled, this will allow the reviewer to interact with the fields aformentioned fields.
When the "Use SSL" checkbox is disabled (check box is not filled with a green color and checkmark), the fields mentioned will dim in brightness, and will not allow interaction.

Disabled "Use SSL" button:

Enabled "Use SSL" button:

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
[/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

qodo-free-for-open-source-projects · 2026-05-03T01:42:00Z

Review Summary by Qodo

Fix fileKeystore field disabled state in Shared Database Login

🐞 Bug fix

Walkthroughs

Description

• Disable fileKeystore field when SSL is not enabled
• Ensures consistent UI behavior across SSL-related fields
• Updated changelog to document the fix

Diagram

flowchart LR
  SSL["SSL Property"] -- "not enabled" --> Disable["Disable Fields"]
  Disable --> FileKeystore["fileKeystore Field"]
  Disable --> Browse["Browse Button"]
  Disable --> Password["Password Field"]

File Changes

1. jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogView.java 🐞 Bug fix +1/-0

Bind fileKeystore disable property to SSL state
• Added binding to disable fileKeystore field when SSL is not enabled
• Aligns fileKeystore disable behavior with browseKeystore and passwordKeystore fields
• Ensures consistent UI state across all SSL-dependent fields
jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogView.java

2. CHANGELOG.md 📝 Documentation +1/-0

Document fileKeystore field disable fix

• Added entry documenting the fix for Shared Database Login Dialog
• References issue #15660 for field requirement consistency

CHANGELOG.md

qodo-free-for-open-source-projects · 2026-05-03T01:42:01Z

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (1) 📎 Requirement gaps (0)

Context used

✅ Tickets: 🎫 Shared Database Login Dialog - Keystore Field Not Disabled when "Use SSL" Box Disabled

1. Changelog entry too technical 📘 Rule violation ⚙ Maintainability

Description

The added CHANGELOG entry is not written in clear, end-user-friendly language and contains awkward
phrasing (e.g., "respective to"), reducing professionalism and readability. This violates the
requirement that CHANGELOG entries be polished and appropriate for the average user.

Code

CHANGELOG.md[104]

+- We fixed the Shared Database Login Dialog by ensuring that fields were required or not required respective to connection information and preferences. [#15660](https://github.com/JabRef/jabref/issues/15660)

Evidence

PR Compliance requires CHANGELOG.md entries to be user-focused and professionally written. The newly
added entry uses unclear/technical wording and unpolished grammar, which does not meet those
documentation quality expectations.

AGENTS.md
CHANGELOG.md[104-104]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly added `CHANGELOG.md` entry is unclear/overly technical and contains awkward phrasing; it should be rewritten to be user-facing and professionally worded.

## Issue Context
CHANGELOG entries are user-facing documentation and should be easy to understand for average users.

## Fix Focus Areas
- CHANGELOG.md[104-104]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Keystore validated when SSL off 🐞 Bug ≡ Correctness

Description

The keystore validator requires a non-empty existing path regardless of SSL state, and the view
subscribes to useSSL in a way that runs the keystore validation visualization even for the current
(unchecked) value. As a result, the keystore can still be treated/visualized as invalid/required
while SSL is disabled.

Code

jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogView.java[134]
+        fileKeystore.disableProperty().bind(viewModel.useSSLProperty().not());

Evidence
The PR disables the keystore field when useSSL is false, but the keystore validation itself is
unconditional: keystoreValidator checks notEmptyAndfilesExist and does not incorporate useSSL.
Additionally, EasyBind.subscribe(...) invokes the subscriber for the current value, so the
keystore visualization hookup runs even when SSL starts unchecked, which is inconsistent with
“keystore required only when SSL is enabled.”
jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogView.java[126-152]
jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogViewModel.java[125-140]
jabgui/src/main/java/org/jabref/gui/util/BindingsHelper.java[173-179]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The keystore field is disabled when `useSSL` is unchecked, but `keystoreValidator` still validates unconditionally and the view wires up visualization via `EasyBind.subscribe`, which runs immediately for the current (unchecked) value. This keeps the keystore in an invalid/required state even when SSL is off.

### Issue Context
Goal: keystore should only be considered required/validated when `useSSL` is enabled.

### Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogViewModel.java[125-140]
- jabgui/src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogView.java[126-152]

### Suggested fix
- Change keystore validation to depend on both `useSSL` and `keystore` so that when `useSSL == false`, the keystore validation is **valid**.
 - For example, create an `ObservableValue<Boolean>` using `EasyBind.combine(keystore, useSSL, (ks, ssl) -> !ssl || (nonEmptyAndExists(ks)))` and validate that boolean.
- Ensure validation status updates when toggling SSL (by making the validator observe `useSSL` via `EasyBind.combine`, rather than only observing the keystore text).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

github-actions · 2026-05-03T01:42:11Z

Do not mark a PR as ready-for-review if changes are required.
Address the changes first.

Siedlerchr · 2026-05-03T17:29:30Z

Can you please take a look a the QODO comment? Is that a valid point?
The second point

…Validators

gandhroh000 · 2026-05-03T20:05:04Z

Can you please take a look a the QODO comment? Is that a valid point? The second point

Yes, you are right thanks for pointing that out, I looked further into it and saw that since keyStoreValidator depends on the useSSL property, it wasn't added as a form validator, even though initialized. I made an additional predicate that incorporated both the notEmptyAndfilesExist and then added to the form validator.

However, I see an additional related issue with the folderValidator or automatically saving the library to field that saves the .bib file accordingly. This validator isn't added either to the form validator, and so with this fix it's about 3 lines of changes to the related issue of improve the Shared Database Login Dialog page, so I would also like to update that as well.

…enabled

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

…enabled

…e_field_enabled" This reverts commit 4dba401, reversing changes made to 1944c4c.

Siedlerchr · 2026-05-03T21:39:16Z

you can ignore the rewrite action for the moment, we are working on a fix in other PR

Siedlerchr · 2026-05-04T18:55:28Z

can you please fix the merge conflicts? I think it was coming from the openrewrite

…enabled

gandhroh000 · 2026-05-04T22:50:58Z

Pulling this from the main branch causes issues, as "eol variable" is no longer declared, and then causes declaration issues. Not sure if the rest of the eol was intended to be removed, but would need this to be fixed prior to fixing merge conflicts.

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

…enabled

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

jabref-machine · 2026-05-05T16:30:59Z

JUnit tests of jabsrv are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

gandhroh000 · 2026-05-05T16:44:16Z

Main changes were to the UI, but it seems like OpenRewrite and other changes in the main branch are causing further issues. Would it be advised to close this pull request, pull from the most updated branch, commit new changes, and then reopen this pull request?

gandhroh000 · 2026-05-05T17:34:24Z

Closing this PR as the main branch fork wasn't synced, causing further issues. Will reopen PR with the same request; however, it will be with the updated repo.

github-actions · 2026-05-05T17:35:19Z

This pull requests was closed without merging. You have been unassigned from the respective issue #15660. In case you closed the PR for yourself, you can re-open it. Please also check After submission of a pull request in CONTRIBUTING.md.

gandhroh000 added 2 commits May 2, 2026 16:05

updated fileKeystore field not disabled when SSL Property is not enabled

dfbe369

Updated the changelog with the updated change

bb298ec

github-actions Bot added the status: changes-required Pull requests that are not yet complete label May 3, 2026

github-actions Bot mentioned this pull request May 3, 2026

Shared Database Login Dialog - Keystore Field Not Disabled when "Use SSL" Box Disabled #15660

Closed

2 tasks

gandhroh000 marked this pull request as ready for review May 3, 2026 01:41

koppor marked this pull request as draft May 3, 2026 01:42

removed obscure language from change log fix description

8903d23

github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels May 3, 2026

updated keyStoreValidator checks the useSSL property and adds to form…

50269ed

…Validators

gandhroh000 and others added 3 commits May 3, 2026 15:05

Merge branch 'main' into fix_to_Database_Login_Dialog_KeyStore_field_…

6bb7a6a

…enabled

Merge branch 'fix_to_Database_Login_Dialog_KeyStore_field_enabled' of h…

1944c4c

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

Merge branch 'main' into fix_to_Database_Login_Dialog_KeyStore_field_…

4dba401

…enabled

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: no-bot-comments labels May 3, 2026

gandhroh000 added 5 commits May 3, 2026 15:41

ran the rewriteRun command

12c77b6

Revert "Merge branch 'main' into fix_to_Database_Login_Dialog_KeyStor…

73a5820

…e_field_enabled" This reverts commit 4dba401, reversing changes made to 1944c4c.

reverting back before manual gradle rewrite command

0ce26b4

reverting back to changelog file from main

a309f4f

ran the rewrite run from the intellij gradle section

062d72f

gandhroh000 and others added 2 commits May 4, 2026 17:15

rewrite ran again

b4311c3

Merge branch 'main' into fix_to_Database_Login_Dialog_KeyStore_field_…

cf0a992

…enabled

gandhroh000 commented May 4, 2026

View reviewed changes

gandhroh000 and others added 6 commits May 4, 2026 18:08

Merge branch 'fix_to_Database_Login_Dialog_KeyStore_field_enabled' of h…

226a5b5

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

attempting to use the main branch copy of LayoutEntry.java file

491e23b

used main branch version copy

28925b6

using main branch layoutentry file version

8e6f4d6

Merge branch 'fix_to_Database_Login_Dialog_KeyStore_field_enabled' of h…

bc55234

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

Merge branch 'main' into fix_to_Database_Login_Dialog_KeyStore_field_…

66754e3

…enabled

github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels May 5, 2026

gandhroh000 added 2 commits May 5, 2026 11:27

removed duplicate line from LayoutEntry.java merge conflict

64a5a52

Merge branch 'fix_to_Database_Login_Dialog_KeyStore_field_enabled' of h…

193737e

…ttps://github.com/gandhroh000/jabref into fix_to_Database_Login_Dialog_KeyStore_field_enabled

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: no-bot-comments labels May 5, 2026

gandhroh000 closed this May 5, 2026

gandhroh000 mentioned this pull request May 7, 2026

Change FileKeystore and Folder fields to disable/enable #15685

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated FileKeystore field not disabled when SSL Property is not enabled#15661

Updated FileKeystore field not disabled when SSL Property is not enabled#15661
gandhroh000 wants to merge 22 commits into
JabRef:mainfrom
gandhroh000:fix_to_Database_Login_Dialog_KeyStore_field_enabled

gandhroh000 commented May 3, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot commented May 3, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented May 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

Siedlerchr commented May 3, 2026 •

edited

Loading

Uh oh!

gandhroh000 commented May 3, 2026

Uh oh!

Siedlerchr commented May 3, 2026

Uh oh!

Siedlerchr commented May 4, 2026

Uh oh!

gandhroh000 May 4, 2026

Uh oh!

jabref-machine commented May 5, 2026

Uh oh!

gandhroh000 commented May 5, 2026

Uh oh!

gandhroh000 commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

gandhroh000 commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

qodo-free-for-open-source-projects Bot commented May 3, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

Siedlerchr commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gandhroh000 commented May 3, 2026

Uh oh!

Siedlerchr commented May 3, 2026

Uh oh!

Siedlerchr commented May 4, 2026

Uh oh!

gandhroh000 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

jabref-machine commented May 5, 2026

Uh oh!

gandhroh000 commented May 5, 2026

Uh oh!

gandhroh000 commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gandhroh000 commented May 3, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented May 3, 2026 •

edited

Loading

Siedlerchr commented May 3, 2026 •

edited

Loading