Skip to content

Added "group" between dropdowns at import#15569

Merged
calixtus merged 4 commits into
JabRef:mainfrom
alex-connick:task-for-issue-15567
Apr 18, 2026
Merged

Added "group" between dropdowns at import#15569
calixtus merged 4 commits into
JabRef:mainfrom
alex-connick:task-for-issue-15567

Conversation

@alex-connick

@alex-connick alex-connick commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Related issues and pull requests

Closes #15567

PR Description

I added a text label saying "group" inbetween the "libraryListView" and "groupListView" drop down box in the ImportEntriesDialog.fxml to give clarity to the function of the "groupListView" drop down box.
task-for-issue-15567

Steps to test

  1. Create an empty library
  2. Click the file button in the top left
  3. Click Import
  4. Click Import to current Library
  5. Select a file
  6. See that the change is there

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add "group" label to Import dialog for clarity

✨ Enhancement

Grey Divider

Walkthroughs

Description 
• Added "group" label to ImportEntriesDialog for clarity
• Label positioned between library and group dropdown boxes
• Updated CHANGELOG.md to document the UI improvement
Diagram 
flowchart LR
  A["ImportEntriesDialog UI"] -- "Add label" --> B["Library dropdown"]
  B -- "New label" --> C["Group label"]
  C -- "Precedes" --> D["Group dropdown"]
Loading

Grey Divider

File Changes

1. CHANGELOG.md 📝 Documentation +1/-0

Document Import GUI group label addition

• Added entry documenting the "group" label addition to Import GUI
• References issue #15567
• Placed in the "Added" section of changelog

CHANGELOG.md

2. jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml ✨ Enhancement +1/-0

Add group label to import dialog layout

• Added new Label element with text "group" in the import dialog
• Label positioned between libraryListView and groupListView ComboBox elements
• Improves UI clarity by labeling the second dropdown's purpose

jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Hardcoded FXML label group ☑ 📘 Rule violation ≡ Correctness
Description 
The new label text group is hardcoded in FXML and is not localized using the required %...
resource key format. This breaks localization and violates the requirement that all user-facing UI
text in FXML must be localized.
Code

jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml[47]

+                        <Label text="group"/>
Evidence 
PR Compliance ID 22 requires FXML user-facing strings to be localized (prefixed with %). The added
line introduces a new user-visible label using text="group" without localization.

AGENTS.md
jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml[47-47]

Agent prompt 
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A new user-facing label was added in FXML as hardcoded text (`group`) instead of using JabRef’s localization mechanism.
## Issue Context
In JabRef FXML files, user-facing strings must be localized by using a resource key prefixed with `%`.
## Fix Focus Areas
- jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml[47-47]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Remediation recommended

2. Changelog line not professional ☑ 📘 Rule violation ⚙ Maintainability
Description 
The added CHANGELOG entry uses unclear/awkward phrasing (`to address clarity for the second drop
down`), which is not professional and may confuse end users. User-facing documentation must be
professionally written and consistently formatted.
Code

CHANGELOG.md[14]

+- We added "group" to address clarity for the second drop down. [#15567](https://github.com/JabRef/jabref/issues/15567)
Evidence 
PR Compliance ID 43 requires user-facing documentation/release notes to be professional and
well-written. The newly added CHANGELOG line contains awkward wording and unclear terminology for
end users.

CHANGELOG.md[14-14]
Best Practice: Learned patterns

Agent prompt 
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new CHANGELOG entry is awkwardly phrased and not end-user friendly.
## Issue Context
Release notes should be professional, clear, and understandable by average users.
## Fix Focus Areas
- CHANGELOG.md[14-14]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@github-actions github-actions Bot added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Apr 17, 2026
@alex-connick alex-connick changed the title Task for issue 15567 Added "group" between dropdowns at import Apr 17, 2026
@github-actions github-actions Bot mentioned this pull request Apr 17, 2026
Closed
@alex-connick

alex-connick commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Thank you Qobo Bot :)

calixtus
calixtus reviewed Apr 17, 2026
View reviewed changes
Comment thread jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml Outdated
calixtus
calixtus reviewed Apr 17, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
calixtus
calixtus requested changes Apr 17, 2026
View reviewed changes

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. Codewise just fine. Just two little nitpicks about wording, then we merge.

@github-actions github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: no-bot-comments labels Apr 17, 2026
@calixtus

calixtus commented Apr 17, 2026

Copy link
Copy Markdown
Member

Sorry about qodo, the bot is sometimes a bit complicated about the changelog.

@github-actions github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels Apr 17, 2026
calixtus
calixtus approved these changes Apr 18, 2026
View reviewed changes

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@calixtus calixtus added this pull request to the merge queue Apr 18, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Apr 18, 2026
Merged via the queue into JabRef:main with commit d7b9cc0 Apr 18, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects[bot] qodo-free-for-open-source-projects[bot] left review comments

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

component: import-load component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. status: no-bot-comments status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add "group" between dropdowns at import

2 participants

@alex-connick @calixtus