Fix casing in automatic field editor#15079
Conversation
Review Summary by QodoFix casing in automatic field editor labels
WalkthroughsDescription• Fixed capitalization in "Keep modifications" label • Fixed capitalization in "Copy or move content" label • Updated localization strings for consistent casing Diagramflowchart LR
A["Automatic Field Editor Dialog"] -->|Update label casing| B["Keep modifications"]
A -->|Update label casing| C["Copy or move content"]
D["Localization strings"] -->|Correct capitalization| B
D -->|Correct capitalization| C
File Changes1. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
✅ All tests passed ✅🏷️ Commit: 142403a Learn more about TestLens at testlens.app. |
Review Summary by QodoFix casing in automatic field editor labels
WalkthroughsDescription• Fixed capitalization in "Keep modifications" label • Fixed capitalization in "Copy or move content" label • Updated localization strings to use consistent lowercase Diagramflowchart LR
A["Localization strings"] -->|"Fix casing"| B["Keep modifications"]
A -->|"Fix casing"| C["Copy or move content"]
B --> D["UI labels corrected"]
C --> D
File Changes1. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java
|
|
Persistent review updated to latest commit b4d70dc |
Review Summary by QodoFix casing in automatic field editor labels
WalkthroughsDescription• Fixed capitalization in "Copy or move content" tab label • Corrected "Keep Modifications" to "Keep modifications" button text • Updated localization strings for consistent casing Diagramflowchart LR
A["Localization Strings"] -->|"Fix casing"| B["JabRef_en.properties"]
B -->|"Update references"| C["CopyOrMoveFieldContentTabView.java"]
B -->|"Update references"| D["AutomaticFieldEditorDialog.fxml"]
C -->|"Display corrected"| E["Tab Label"]
D -->|"Display corrected"| F["Button Text"]
File Changes1. jablib/src/main/resources/l10n/JabRef_en.properties
|
|
Persistent review updated to latest commit b4d70dc |
| @Override | ||
| public String getTabName() { | ||
| return Localization.lang("Copy or Move content"); | ||
| return Localization.lang("Copy or move content"); |
There was a problem hiding this comment.
2. copy or move content key 📘 Rule violation ✓ Correctness
The PR changes the localization key casing from Copy or Move content to Copy or move content, but other locale files still define only the old key, which can cause untranslated tab titles in non-English locales. This violates the requirement to reuse existing localization strings and keep user-facing text properly localized.
Agent Prompt
## Issue description
The PR introduces a new localization key (`Copy or move content`) by changing key casing, but other locales still provide translations for the existing key (`Copy or Move content`). This can cause missing translations in non-English locales.
## Issue Context
Localization keys should remain stable across all `JabRef_*.properties` files. Changing the key text in Java creates a new lookup key and bypasses existing translations.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java[90-90]
- jablib/src/main/resources/l10n/JabRef_en.properties[2605-2605]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
No need to address - see https://devdocs.jabref.org/code-howtos/localization.html#adding-a-new-key
Review Summary by QodoFix capitalization in Automatic Field Editor labels across all languages
WalkthroughsDescription• Fixed capitalization inconsistencies in Automatic Field Editor UI labels • Changed "Copy or Move content" to "Copy or move content" across all languages • Changed "Keep Modifications" to "Keep modifications" across all languages • Updated CHANGELOG.md to document the fix Diagramflowchart LR
A["UI Labels<br/>Inconsistent Casing"] -->|Fix| B["Lowercase 'move'<br/>and 'modifications'"]
C["Java Code<br/>CopyOrMoveFieldContentTabView.java"] -->|Update| B
D["FXML Dialog<br/>AutomaticFieldEditorDialog.fxml"] -->|Update| B
E["Localization Files<br/>14 language properties"] -->|Update| B
B -->|Result| F["Consistent UI<br/>Capitalization"]
File Changes1. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java
|
|
Persistent review updated to latest commit 142403a |
Closes #15068
Fixed the capitalization errors in "Keep modifications" and "Copy or move content" labels within the Automatic Field Editor dialog. I wanted to add screenshots of the changes but sadly , even after 3 hours of struggle i couldn't open jabref on my computer.
Steps to test
Open JabRef with a test library (e.g. chocolate.bib).
Select all entries.
Go to Edit -> Automatic field editor.
Verify that the checkboxes now correctly display "Keep modifications" and "Copy or move content" (with lowercase 'm').
Checklist