Skip to content

Fix casing in automatic field editor#15079

Merged
koppor merged 5 commits into
JabRef:mainfrom
Hamsyz:fix-for-Localization-casing
Feb 11, 2026
Merged

Fix casing in automatic field editor#15079
koppor merged 5 commits into
JabRef:mainfrom
Hamsyz:fix-for-Localization-casing

Conversation

@Hamsyz

@Hamsyz Hamsyz commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Closes #15068

Fixed the capitalization errors in "Keep modifications" and "Copy or move content" labels within the Automatic Field Editor dialog. I wanted to add screenshots of the changes but sadly , even after 3 hours of struggle i couldn't open jabref on my computer.

Steps to test
Open JabRef with a test library (e.g. chocolate.bib).

Select all entries.

Go to Edit -> Automatic field editor.

Verify that the checkboxes now correctly display "Keep modifications" and "Copy or move content" (with lowercase 'm').

image image

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number.
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Fix casing in automatic field editor labels

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Fixed capitalization in "Keep modifications" label
• Fixed capitalization in "Copy or move content" label
• Updated localization strings for consistent casing
Diagram
flowchart LR
  A["Automatic Field Editor Dialog"] -->|Update label casing| B["Keep modifications"]
  A -->|Update label casing| C["Copy or move content"]
  D["Localization strings"] -->|Correct capitalization| B
  D -->|Correct capitalization| C
Loading

Grey Divider

File Changes

1. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java 🐞 Bug fix +1/-1

Fix tab name capitalization

• Changed tab name from "Copy or Move content" to "Copy or move content"
• Corrected capitalization to match localization standards

jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java


2. jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml 🐞 Bug fix +1/-1

Fix button label capitalization

• Updated button text from "%Keep Modifications" to "%Keep modifications"
• Corrected capitalization in FXML dialog definition

jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml


3. jablib/src/main/resources/l10n/JabRef_en.properties 🐞 Bug fix +2/-2

Fix localization string capitalization

• Changed "Copy or Move content" to "Copy or move content"
• Changed "Keep Modifications" to "Keep modifications"
• Updated two localization string entries for consistent casing

jablib/src/main/resources/l10n/JabRef_en.properties


Grey Divider

Qodo Logo

@github-actions github-actions Bot added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 10, 2026
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment thread jablib/src/main/resources/l10n/JabRef_en.properties
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Feb 10, 2026
@github-actions github-actions Bot mentioned this pull request Feb 10, 2026
2 tasks
@testlens-app

testlens-app Bot commented Feb 10, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 142403a
▶️ Tests: 11187 executed
⚪️ Checks: 61/61 completed


Learn more about TestLens at testlens.app.

@koppor koppor marked this pull request as draft February 11, 2026 08:30
@Hamsyz Hamsyz marked this pull request as ready for review February 11, 2026 09:14
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Fix casing in automatic field editor labels

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Fixed capitalization in "Keep modifications" label
• Fixed capitalization in "Copy or move content" label
• Updated localization strings to use consistent lowercase
Diagram
flowchart LR
  A["Localization strings"] -->|"Fix casing"| B["Keep modifications"]
  A -->|"Fix casing"| C["Copy or move content"]
  B --> D["UI labels corrected"]
  C --> D
Loading

Grey Divider

File Changes

1. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java 🐞 Bug fix +1/-1

Fix tab name capitalization

• Changed tab name from "Copy or Move content" to "Copy or move content"
• Fixed capitalization to use lowercase 'm' in "move"

jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java


2. jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml 🐞 Bug fix +1/-1

Fix button label capitalization

• Changed button text from "%Keep Modifications" to "%Keep modifications"
• Fixed capitalization to use lowercase 'm' in "modifications"

jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml


3. jablib/src/main/resources/l10n/JabRef_en.properties 🐞 Bug fix +2/-2

Fix localization string capitalization

• Changed "Copy\ or\ Move\ content" to "Copy\ or\ move\ content"
• Changed "Keep\ Modifications" to "Keep\ modifications"
• Updated localization keys to use consistent lowercase formatting

jablib/src/main/resources/l10n/JabRef_en.properties


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit b4d70dc

@koppor koppor marked this pull request as draft February 11, 2026 09:27
@Hamsyz Hamsyz marked this pull request as ready for review February 11, 2026 09:48
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Fix casing in automatic field editor labels

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Fixed capitalization in "Copy or move content" tab label
• Corrected "Keep Modifications" to "Keep modifications" button text
• Updated localization strings for consistent casing
Diagram
flowchart LR
  A["Localization Strings"] -->|"Fix casing"| B["JabRef_en.properties"]
  B -->|"Update references"| C["CopyOrMoveFieldContentTabView.java"]
  B -->|"Update references"| D["AutomaticFieldEditorDialog.fxml"]
  C -->|"Display corrected"| E["Tab Label"]
  D -->|"Display corrected"| F["Button Text"]
Loading

Grey Divider

File Changes

1. jablib/src/main/resources/l10n/JabRef_en.properties 🐞 Bug fix +2/-2

Fix capitalization in localization strings

• Changed "Copy or Move content" to "Copy or move content" for consistent casing
• Changed "Keep Modifications" to "Keep modifications" for consistent casing
• Updated localization keys to match corrected text

jablib/src/main/resources/l10n/JabRef_en.properties


2. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java 🐞 Bug fix +1/-1

Update tab name localization reference

• Updated getTabName() method to use corrected localization key "Copy or move content"
• Changed from "Copy or Move content" to match localization fix

jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java


3. jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml 🐞 Bug fix +1/-1

Fix button text localization reference

• Updated ButtonType text attribute from "%Keep Modifications" to "%Keep modifications"
• Corrected casing to match localization string updates

jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit b4d70dc

@Override
public String getTabName() {
return Localization.lang("Copy or Move content");
return Localization.lang("Copy or move content");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. copy or move content key 📘 Rule violation ✓ Correctness

The PR changes the localization key casing from Copy or Move content to Copy or move content,
but other locale files still define only the old key, which can cause untranslated tab titles in
non-English locales. This violates the requirement to reuse existing localization strings and keep
user-facing text properly localized.
Agent Prompt
## Issue description
The PR introduces a new localization key (`Copy or move content`) by changing key casing, but other locales still provide translations for the existing key (`Copy or Move content`). This can cause missing translations in non-English locales.

## Issue Context
Localization keys should remain stable across all `JabRef_*.properties` files. Changing the key text in Java creates a new lookup key and bypasses existing translations.

## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java[90-90]
- jablib/src/main/resources/l10n/JabRef_en.properties[2605-2605]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay , thanks.

@koppor koppor marked this pull request as draft February 11, 2026 10:26
@github-actions github-actions Bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels Feb 11, 2026
@Hamsyz Hamsyz marked this pull request as ready for review February 11, 2026 11:06
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Fix capitalization in Automatic Field Editor labels across all languages

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Fixed capitalization inconsistencies in Automatic Field Editor UI labels
• Changed "Copy or Move content" to "Copy or move content" across all languages
• Changed "Keep Modifications" to "Keep modifications" across all languages
• Updated CHANGELOG.md to document the fix
Diagram
flowchart LR
  A["UI Labels<br/>Inconsistent Casing"] -->|Fix| B["Lowercase 'move'<br/>and 'modifications'"]
  C["Java Code<br/>CopyOrMoveFieldContentTabView.java"] -->|Update| B
  D["FXML Dialog<br/>AutomaticFieldEditorDialog.fxml"] -->|Update| B
  E["Localization Files<br/>14 language properties"] -->|Update| B
  B -->|Result| F["Consistent UI<br/>Capitalization"]
Loading

Grey Divider

File Changes

1. jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java 🐞 Bug fix +1/-1

Update tab name capitalization to lowercase

jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabView.java


2. jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml 🐞 Bug fix +1/-1

Fix button label capitalization in dialog

jabgui/src/main/resources/org/jabref/gui/edit/automaticfiededitor/AutomaticFieldEditorDialog.fxml


3. jablib/src/main/resources/l10n/JabRef_en.properties 🐞 Bug fix +2/-2

Fix English localization capitalization errors

jablib/src/main/resources/l10n/JabRef_en.properties


View more (12)
4. jablib/src/main/resources/l10n/JabRef_de.properties 🐞 Bug fix +2/-2

Fix German localization capitalization errors

jablib/src/main/resources/l10n/JabRef_de.properties


5. jablib/src/main/resources/l10n/JabRef_es.properties 🐞 Bug fix +2/-2

Fix Spanish localization capitalization errors

jablib/src/main/resources/l10n/JabRef_es.properties


6. jablib/src/main/resources/l10n/JabRef_fr.properties 🐞 Bug fix +2/-2

Fix French localization capitalization errors

jablib/src/main/resources/l10n/JabRef_fr.properties


7. jablib/src/main/resources/l10n/JabRef_it.properties 🐞 Bug fix +2/-2

Fix Italian localization capitalization errors

jablib/src/main/resources/l10n/JabRef_it.properties


8. jablib/src/main/resources/l10n/JabRef_ja.properties 🐞 Bug fix +2/-2

Fix Japanese localization capitalization errors

jablib/src/main/resources/l10n/JabRef_ja.properties


9. jablib/src/main/resources/l10n/JabRef_nl.properties 🐞 Bug fix +2/-2

Fix Dutch localization capitalization errors

jablib/src/main/resources/l10n/JabRef_nl.properties


10. jablib/src/main/resources/l10n/JabRef_pl.properties 🐞 Bug fix +1/-1

Fix Polish localization capitalization errors

jablib/src/main/resources/l10n/JabRef_pl.properties


11. jablib/src/main/resources/l10n/JabRef_pt_BR.properties 🐞 Bug fix +2/-2

Fix Brazilian Portuguese localization capitalization errors

jablib/src/main/resources/l10n/JabRef_pt_BR.properties


12. jablib/src/main/resources/l10n/JabRef_tr.properties 🐞 Bug fix +2/-2

Fix Turkish localization capitalization errors

jablib/src/main/resources/l10n/JabRef_tr.properties


13. jablib/src/main/resources/l10n/JabRef_zh_CN.properties 🐞 Bug fix +2/-2

Fix Simplified Chinese localization capitalization errors

jablib/src/main/resources/l10n/JabRef_zh_CN.properties


14. jablib/src/main/resources/l10n/JabRef_ar.properties 🐞 Bug fix +1/-1

Fix Arabic localization capitalization errors

jablib/src/main/resources/l10n/JabRef_ar.properties


15. CHANGELOG.md 📝 Documentation +1/-0

Document capitalization fix in changelog

CHANGELOG.md


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 142403a

@koppor koppor added this pull request to the merge queue Feb 11, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Feb 11, 2026
Merged via the queue into JabRef:main with commit add8b24 Feb 11, 2026
62 of 63 checks passed
@Hamsyz Hamsyz deleted the fix-for-Localization-casing branch February 11, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue An issue intended for project-newcomers. Varies in difficulty. status: no-bot-comments status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix casing

2 participants