Skip to content

Fix rename subgroup and move it under "Edit group"#15061

Merged
koppor merged 13 commits into
JabRef:mainfrom
LoayTarek5:fix-rename-subgroup-15041
Feb 9, 2026
Merged

Fix rename subgroup and move it under "Edit group"#15061
koppor merged 13 commits into
JabRef:mainfrom
LoayTarek5:fix-rename-subgroup-15041

Conversation

@LoayTarek5

@LoayTarek5 LoayTarek5 commented Feb 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #15041

move the "Rename subgroup" option in the group context menu to immediately after "Edit group".
Also, renamed it to "Rename group".

Steps to test

1-Look at the left panel (Groups panel)
2- Click the "Add group" button or choose any existing group
3- Open the context menu by right-clicking on the group you just created or chose
image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number.
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Reorganize group context menu and rename action

✨ Enhancement

Grey Divider

Walkthroughs

Description 
• Rename "Rename subgroup" action to "Rename group"
• Move "Rename group" menu item below "Edit group"
• Update CHANGELOG and localization strings
Diagram 
flowchart LR
  A["Group Context Menu"] -->|"Move & Rename"| B["Rename subgroup → Rename group"]
  B -->|"New Position"| C["Below Edit group"]
  D["StandardActions enum"] -->|"Update label"| B
  E["Localization files"] -->|"Remove old entry"| B
Loading

Grey Divider

File Changes

1. jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java ✨ Enhancement +1/-1

Update action label to Rename group

• Changed GROUP_SUBGROUP_RENAME action label from "Rename subgroup" to "Rename group"
• Maintains existing KeyBinding reference

jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java

2. jabgui/src/main/java/org/jabref/gui/groups/GroupTreeView.java ✨ Enhancement +1/-1

Reposition rename action in context menu

• Moved GROUP_SUBGROUP_RENAME menu item to immediately after GROUP_EDIT
• Removed it from its previous position in the subgroup operations section
• Maintains same context action functionality

jabgui/src/main/java/org/jabref/gui/groups/GroupTreeView.java

3. CHANGELOG.md 📝 Documentation +1/-0

Document menu reorganization change

• Added entry documenting the rename and repositioning of "Rename subgroup" to "Rename group"
• References issue #15041

CHANGELOG.md

View more (1)
4. jablib/src/main/resources/l10n/JabRef_en.properties Localization +0/-1

Remove old localization string

• Removed obsolete "Rename subgroup" localization entry
• Action now uses updated "Rename group" label from StandardActions

jablib/src/main/resources/l10n/JabRef_en.properties

Grey Divider

Qodo Logo

@github-actions github-actions Bot added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 8, 2026
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

✅ 1. Changelog uses wrong tense 📘 Rule violation ✓ Correctness
Description 
• The changelog entry uses the phrase and rename to, which is grammatically incorrect in context.
• This reduces professionalism/clarity for end users reading release notes and violates the
  typo-free text requirement.
Code

CHANGELOG.md[40]

+- We moved the "Rename subgroup" below "Edit group" and rename to "Rename group". [#15041](https://github.com/JabRef/jabref/issues/15041)
Evidence 
PR Compliance ID 24 requires modified changelog entries to be typo-free and professionally written.
The modified line in CHANGELOG.md contains a grammar mistake (rename instead of renamed).

CHANGELOG.md[40-40]
Best Practice: Learned patterns

Agent prompt 
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The changelog entry has a grammatical error (`and rename to`) and should be corrected to a professional, typo-free sentence.
## Issue Context
This is user-facing release-note text and must be clear and grammatically correct.
## Fix Focus Areas
- CHANGELOG.md[40-40]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@github-actions github-actions Bot mentioned this pull request Feb 8, 2026
Closed
koppor
koppor requested changes Feb 8, 2026
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address #15061 (comment)

@github-actions github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: changes-required Pull requests that are not yet complete labels Feb 8, 2026
@testlens-app

testlens-app Bot commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 1ed1354
▶️ Tests: 11185 executed
⚪️ Checks: 51/51 completed

Learn more about TestLens at testlens.app.

@LoayTarek5 LoayTarek5 requested a review from koppor February 8, 2026 18:26
koppor
koppor requested changes Feb 8, 2026
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency please

Comment thread jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java Outdated
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Feb 8, 2026
@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Feb 9, 2026
@LoayTarek5 LoayTarek5 requested a review from koppor February 9, 2026 06:20
@koppor koppor added this pull request to the merge queue Feb 9, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Feb 9, 2026
Merged via the queue into JabRef:main with commit c331e17 Feb 9, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

good first issue An issue intended for project-newcomers. Varies in difficulty. status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Rename subgroup" should be "Rename group"

2 participants

@LoayTarek5 @koppor