Skip to content

Default lower-case name for "imported entries" group.#14998

Closed
koppor wants to merge 2 commits into
mainfrom
lower-case-imported-entries
Closed

Default lower-case name for "imported entries" group.#14998
koppor wants to merge 2 commits into
mainfrom
lower-case-imported-entries

Conversation

@koppor

@koppor koppor commented Feb 2, 2026 •
edited by qodo-free-for-open-source-projects Bot
Loading

Copy link
Copy Markdown
Member

User description

I am using all-lowercase group names - and was a bit disturbed that JabRef uses sentence case.

However, I saw Cholocate.bib which uses, sentence case, too.

Opinions? I am open to both - move forward or to reject.

Steps to test

  1. Freshly installed JabRef
  2. Enable "import entries" group in preferences
  3. See that all lower case.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

PR Type

Enhancement

Description

  • Changed default "imported entries" group name to lowercase

  • Updated test expectations to match new lowercase naming convention

  • Modified localization strings for consistency with lowercase preference

  • Reorganized localization properties file for better structure

Diagram Walkthrough

flowchart LR
  A["Default Group Name"] -- "changed from sentence case" --> B["Imported entries"]
  B -- "to lowercase" --> C["imported entries"]
  D["Test Assertions"] -- "updated to match" --> C
  E["Localization Strings"] -- "updated to match" --> C
Loading

File Walkthrough
Relevant files
Tests
GroupTreeViewModelTest.java
Update test expectations for lowercase group name               

jabgui/src/test/java/org/jabref/gui/groups/GroupTreeViewModelTest.java

  • Updated test setup to use lowercase "imported entries" as default
    group name
  • Modified assertion in shouldCreateImportedEntriesGroupWhenEnabled()
    test to expect lowercase name
 +2/-2     
Configuration changes
JabRefCliPreferences.java
Update default imported entries group name preference       

jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java

  • Changed default value for ADD_IMPORTED_ENTRIES_GROUP_NAME from
    "Imported entries" to "imported entries"
 +1/-1     
Localization
JabRef_en.properties
Update localization strings to lowercase                                 

jablib/src/main/resources/l10n/JabRef_en.properties

  • Changed localization key from "Imported entries" to "imported entries"
    (lowercase)
  • Reorganized properties file by moving "%0 entry(s) imported" entry to
    different location
 +2/-3     
Documentation
CHANGELOG.md
Document lowercase group name change                                         

CHANGELOG.md

  • Added entry documenting the change to lowercase default name for
    imported entries group
 +1/-0     

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Avoid changing localization keys directly

Revert the localization key from "imported entries" back to "Imported entries"
in JabRefCliPreferences.java. Changing localization keys breaks existing
translations in other languages.

jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java [512]

-defaults.put(ADD_IMPORTED_ENTRIES_GROUP_NAME, Localization.lang("imported entries"));
+defaults.put(ADD_IMPORTED_ENTRIES_GROUP_NAME, Localization.lang("Imported entries"));
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies a critical internationalization issue where changing a localization key breaks existing translations in other languages, which is a significant regression.

High
Keep localization key for compatibility

In the properties file, keep the localization key as "Imported entries" for
backward compatibility and change its value to "imported entries" to implement
the desired change.

jablib/src/main/resources/l10n/JabRef_en.properties [2564-2566]

 Add\ imported\ entries\ to\ group=Add imported entries to group
--Imported\ entries=Imported entries
-+imported\ entries=imported entries
-+%0\ entry(s)\ imported=%0 entry(s) imported
+Imported\ entries=imported entries
+%0\ entry(s)\ imported=%0 entry(s) imported
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies a critical internationalization issue where changing a localization key breaks existing translations in other languages, which is a significant regression.

High
  • Update

@koppor koppor mentioned this pull request Feb 2, 2026
Merged
3 tasks
@Siedlerchr

Siedlerchr commented Feb 2, 2026

Copy link
Copy Markdown
Member

But All entries is also sentence case

@koppor

koppor commented Feb 2, 2026

Copy link
Copy Markdown
Member Author

But All entries is also sentence case

Yeah, I saw this - not sure if

  • that should be changed, too
  • this PR just closed ^^
  • or a toggle "sentence-cased automatic groups" and "lower-cased automatic groups" be added

I think, the second option is best maybe?

@Siedlerchr

Siedlerchr commented Feb 2, 2026

Copy link
Copy Markdown
Member

I personally prefer sentence ase

@Siedlerchr Siedlerchr closed this Feb 2, 2026
@koppor koppor deleted the lower-case-imported-entries branch February 2, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr