Fix #14948: imported entries group should not focus it by LoayTarek5 · Pull Request #14983 · JabRef/jabref

LoayTarek5 · 2026-02-01T09:59:42Z

User description

Fixed an issue where the "Imported entries" group was being automatically selected/focused when switching between library tabs, even when the group was empty and no import operation was occurring.
The fix removes the unwanted auto-selection behavior, while still creating the group when the preference is enabled.
Now the group is only selected when explicitly chosen by the user or during an actual import operation.

Steps to test

Go to Preferences → Library
Enable the checkbox "Automatically assign imported entries to group"
Open or create at least 2 different .bib library files (so you have multiple tabs)
In the first library tab, select any group other than "Imported entries"
Switch to the second library tab
Switch back to the first library tab
Create a new library (or use one without the "Imported entries" group)
Switch to another tab and back
Go to Preferences → Library
Disable the checkbox "Automatically assign imported entries to group"
Switch between library tabs

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

PR Type

Bug fix

Description

Removes auto-selection of "Imported entries" group on tab switch
Group still created when preference enabled, but not focused
Prevents unwanted focus theft when switching library tabs

Diagram Walkthrough

flowchart LR
  A["Tab Switch Event"] --> B["Check Preference Enabled"]
  B --> C["Create Group if Missing"]
  C --> D["Skip Auto-Selection"]
  D --> E["User Retains Current Selection"]

File Walkthrough

Relevant files

Bug fix

GroupTreeViewModel.java `Remove auto-selection of imported entries group` jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java Removed `selectedGroups.setAll()` call that auto-selected the imported entries group Added clarifying comments explaining group creation without selection Group is now created when preference enabled but not automatically focused	+2/-1

Documentation

CHANGELOG.md `Document imported entries group fix` CHANGELOG.md Added entry documenting the fix for issue Creation of the "Imported Entries" group should not focus it #14948 Describes the resolved auto-selection behavior on tab switching	+1/-0

github-actions · 2026-02-01T09:59:52Z

Hey @LoayTarek5! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide.

Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures.

qodo-free-for-open-source-projects · 2026-02-01T10:00:07Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance

🟢

No security concerns identified

No security vulnerabilities detected by AI analysis. Human verification advised for critical code.

Ticket Compliance

🟡

🎫 #13109

🔴	Make the Pseudonymization functionality available on the CLI
	Implement similar CLI experience as the consistency check
	Follow the implementation pattern of the CheckConsistency class

🟡

🎫 #14948

🟢	Prevent automatic selection/focus of the "Imported Entries" group when switching between library tabs
	Ensure the group is still created when the preference is enabled
⚪	Fix the issue where the group shows as selected with 0 entries while the main table shows entries
	The fix should apply when multiple bib files are opened and the import to group preference is activated

Codebase Duplication Compliance

⚪

Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance

🟢

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

qodo-free-for-open-source-projects · 2026-02-01T10:00:49Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category Suggestion Impact

Possible issue

Add null check to prevent crash

Add a null check for the parent parameter in the addGroupImportEntries method to
prevent a potential NullPointerException.

jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java [189-209]

 private void addGroupImportEntries(GroupNodeViewModel parent) {
-    if (!preferences.getLibraryPreferences().isAddImportedEntriesEnabled()) {
+    if (parent == null || !preferences.getLibraryPreferences().isAddImportedEntriesEnabled()) {
         return;
     }
 
     String groupName = preferences.getLibraryPreferences().getAddImportedEntriesGroupName();
     boolean groupExists = parent.getGroupNode()
                                 .getChildren()
                                 .stream()
                                 .map(GroupTreeNode::getGroup)
                                 .anyMatch(grp -> grp instanceof ExplicitGroup && grp.getName().equals(groupName));
     if (!groupExists) {
         currentDatabase.ifPresent(db -> {
             char keywordSeparator = preferences.getBibEntryPreferences().getKeywordSeparator();
             AbstractGroup importEntriesGroup = new ExplicitGroup(groupName, GroupHierarchyType.INDEPENDENT, keywordSeparator);
             GroupTreeNode newSubgroup = parent.addSubgroup(importEntriesGroup);
             newSubgroup.moveTo(parent.getGroupNode(), 0);
             writeGroupChangesToMetaData();
         });
     }
 }

Apply / Chat

Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a potential NullPointerException because addGroupImportEntries can be called with a null parent from onActiveDatabaseChanged. Adding a null check is a robust way to prevent this potential crash.

Medium

Update

…s-group

koppor

Tried out locally. Works fine. Just added a dot to the end of the two sentecnes.

…java

koppor · 2026-02-01T23:08:22Z

Now the group is only selected when explicitly chosen by the user or during an actual import operation.

Side note: You don't need to anonymize a bibtex file with zero entries. -- You have "create example library" in the Welcome Tab and https://github.com/JabRef/jabref-demonstration-libraries/ for examples.

LoayTarek5 added 2 commits February 1, 2026 11:04

Update CHANGELOG for auto-select 'Imported entries' group on tab switch

4a37a02

Remove auto-selection of 'Imported entries' group

9a08c7b

github-actions Bot added first contrib status: changes-required Pull requests that are not yet complete labels Feb 1, 2026

qodo-free-for-open-source-projects Bot added the Review effort 2/5 label Feb 1, 2026

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Feb 1, 2026

LoayTarek5 force-pushed the fix-imported-entries-group branch 2 times, most recently from 8514929 to 0372f95 Compare February 1, 2026 11:25

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Feb 1, 2026

Merge remote-tracking branch 'upstream/main' into fix-imported-entrie…

c5944db

…s-group

LoayTarek5 force-pushed the fix-imported-entries-group branch from 0372f95 to c5944db Compare February 1, 2026 11:49

LoayTarek5 added 2 commits February 1, 2026 13:52

style: trigger CI with standard push

06c51ad

fix markdown linting

692d659

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Feb 1, 2026

Merge branch 'main' into fix-imported-entries-group

be73932

LoayTarek5 changed the title ~~Fix imported entries group~~ Fix #14948: imported entries group should not focus it Feb 1, 2026

github-actions Bot added the good second issue Issues that involve a tour of two or three interweaved components in JabRef label Feb 1, 2026

koppor reviewed Feb 1, 2026

View reviewed changes

Comment thread jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java Outdated

Update jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.…

76c2d77

…java

koppor enabled auto-merge February 1, 2026 23:06

koppor approved these changes Feb 1, 2026

View reviewed changes

koppor added this pull request to the merge queue Feb 1, 2026

github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Feb 1, 2026

Merged via the queue into JabRef:main with commit 227c3e7 Feb 1, 2026
50 of 51 checks passed

github-actions Bot mentioned this pull request Feb 1, 2026

Creation of the "Imported Entries" group should not focus it #14948

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #14948: imported entries group should not focus it#14983

Fix #14948: imported entries group should not focus it#14983
koppor merged 7 commits into
JabRef:mainfrom
LoayTarek5:fix-imported-entries-group

LoayTarek5 commented Feb 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 1, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 1, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 1, 2026 •

edited

Loading

Uh oh!

koppor left a comment

Uh oh!

Uh oh!

koppor commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

LoayTarek5 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Steps to test

Mandatory checks

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

github-actions Bot commented Feb 1, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Compliance Guide 🔍

Uh oh!

qodo-free-for-open-source-projects Bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

koppor commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LoayTarek5 commented Feb 1, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Feb 1, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Feb 1, 2026 •

edited

Loading