Skip to content

Remember opened side panes#14830

Merged
Siedlerchr merged 1 commit into
mainfrom
fixPrefsSidePane
Jan 9, 2026
Merged

Remember opened side panes#14830
Siedlerchr merged 1 commit into
mainfrom
fixPrefsSidePane

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #14818

Steps to test

  • Close all side panes
  • Restart JabRef
  • Side panes still closed

Just open groups

  • Restart JabRef
  • Only groups is shown

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #13109
🔴 Make `org.jabref.logic.pseudonymization.Pseudonymization` available on the CLI
Provide similar CLI experience to consistency check
Implement similar to `org.jabref.cli.CheckConsistency` class
🟡
🎫 #14818
🟢 Remember display settings from one session to another for side panels
⚪ Prevent Web search and Search panels from automatically opening at the left of the screen
on every launch
Allow user to control whether side panels open on launch
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

⚪
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
Empty Collection Handling: The removal of empty checks for backingStoreVisiblePanes and
backingStorePreferredPositions may cause unexpected behavior if empty collections have
different semantics than defaults in downstream code.

Referred Code 
return new SidePanePreferences(
        backingStoreVisiblePanes,
        backingStorePreferredPositions,

Learn more about managing compliance generic rules or creating your own custom rules
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 9, 2026
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Siedlerchr Siedlerchr enabled auto-merge January 9, 2026 20:20
@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 2743fbf Jan 9, 2026
94 of 113 checks passed
@Siedlerchr Siedlerchr deleted the fixPrefsSidePane branch January 9, 2026 22:30
@github-actions github-actions Bot mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

Review effort 2/5 status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

default opening of the search panel upon new launch

2 participants

@Siedlerchr @calixtus