Added MonthPlausibilityComparator to prefer normalized months by D-Prasanth-Kumar · Pull Request #14629 · JabRef/jabref

D-Prasanth-Kumar · 2025-12-16T06:35:10Z

User description

Closes #14457

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Screenshot

Merge Dialog automatically preferring the normalized month format

PR Type

Enhancement

Description

Added MonthPlausibilityComparator to intelligently compare month field values
Prefers normalized months (#jun#) and integers over plain text strings
Integrated comparator into merge dialog for automatic field selection
Added comprehensive unit tests and JavaDoc documentation

Diagram Walkthrough

flowchart LR
  A["Month Field Values"] -->|Parse & Compare| B["MonthPlausibilityComparator"]
  B -->|Check Format| C["isStrictFormat"]
  C -->|Prefer| D["Normalized/Integer Format"]
  D -->|Result| E["Merge Dialog Auto-Selection"]

File Walkthrough

Relevant files

Enhancement

MonthPlausibilityComparator.java `New month field value comparator implementation` jablib/src/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java New comparator class implementing `FieldValuePlausibilityComparator` interface Compares two month values and prefers normalized formats (#jun#) or integers Returns `UNDETERMINED` when months differ or both are unparseable Delegates format checking to `Month.isStrictFormat()` method	+44/-0
Month.java `Add strict format validation for month values` jablib/src/main/java/org/jabref/model/entry/Month.java Added static method `isStrictFormat()` to check if month value is in strict BibTeX format Recognizes integers (e.g., "6") and BibTeX strings (e.g., "#jun#") as strict format Plain text months (e.g., "June") are considered non-strict format	+17/-0
PlausibilityComparatorFactory.java `Register month comparator in factory` jablib/src/main/java/org/jabref/logic/bibtex/comparator/plausibility/PlausibilityComparatorFactory.java Integrated `MonthPlausibilityComparator` into factory pattern Returns comparator when field has `FieldProperty.MONTH` property Follows existing pattern used for person names and year fields	+3/-0
FieldRowViewModel.java `Enable auto-selection in field row view model` jabgui/src/main/java/org/jabref/gui/mergeentries/threewaymerge/FieldRowViewModel.java Added call to `autoSelectBetterValue()` in constructor initialization Enables automatic selection of better month format during merge operations	+2/-0

Tests

MonthPlausibilityComparatorTest.java `Comprehensive unit tests for month comparator` jablib/src/test/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparatorTest.java New parameterized test class with 12 test cases covering various month comparison scenarios Tests preference of normalized formats over plain text Tests handling of invalid/unparseable month values Tests comparison of different months returning `UNDETERMINED`	+37/-0

Documentation

CHANGELOG.md `Document month comparator feature in changelog` CHANGELOG.md Added entry documenting new month field plausibility comparator feature Explains preference for normalized months and integers in merge dialog References issue Add MonthPlausibilityComparator #14457	+1/-0

koppor

Please learn from last PRs We don't want to repeat the same comments over and over again.

#14546 (comment)

D-Prasanth-Kumar · 2025-12-16T07:56:45Z

Please learn from last PRs We don't want to repeat the same comments over and over again.

#14546 (comment)

I am sorry for causing you to repeat this feedback. I am adding the test case immediately

koppor

Tests should be created using @ParameterizedTest

koppor

Code does not cover all cases.

Moreover, org.jabref.model.entry.Month#parse should be used to check for validity.

github-actions · 2025-12-20T03:30:02Z

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

calixtus · 2025-12-22T22:42:48Z

Please change the test according to @koppor s comment and adapt the code. (TTD)

D-Prasanth-Kumar · 2025-12-23T01:58:22Z

Thanks for the guidance @koppor @HoussemNasri @calixtus. This PR has become quite complicated with the various changes and merge conflicts. I’ve decided to close it for now to rethink the approach and perhaps start fresh later.

github-actions · 2025-12-23T01:59:34Z

This pull requests was closed without merging. You have been unassigned from the respective issue #14457. In case you closed the PR for yourself, you can re-open it. Please also check After submission of a pull request in the CONTRIBUTING.md

koppor · 2026-01-22T07:47:09Z

I think, we are close to merging now :). Please merge upstream/main to have the latest tests also in your branch.

D-Prasanth-Kumar · 2026-01-23T19:03:00Z

@koppor can you once review the pr, as the pr is created way back there were lot of things happened and after having the latest changes to my branch there were few failed builds ...

…ty-comparator

koppor

Looks good now. Thank you for following-up.

github-actions Bot added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Dec 16, 2025

koppor requested changes Dec 16, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 16, 2025

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 16, 2025

calixtus added the component: merge Merging of BibTeX entries, merge entry dialog, diffing ... label Dec 16, 2025

calixtus reviewed Dec 16, 2025

View reviewed changes

Comment thread jabgui/src/main/java/org/jabref/gui/mergeentries/threewaymerge/FieldRowViewModel.java

calixtus assigned HoussemNasri Dec 16, 2025

koppor requested changes Dec 17, 2025

View reviewed changes

Comment thread ...st/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparatorTest.java Outdated

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 17, 2025

koppor requested changes Dec 17, 2025

View reviewed changes

Comment thread ...c/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java Outdated

Comment thread ...c/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java Outdated

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 17, 2025

HoussemNasri reviewed Dec 17, 2025

View reviewed changes

Comment thread ...c/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java Outdated

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 20, 2025

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: changes-required Pull requests that are not yet complete labels Dec 20, 2025

HoussemNasri reviewed Dec 22, 2025

View reviewed changes

Comment thread ...c/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java Outdated

koppor requested changes Dec 22, 2025

View reviewed changes

Comment thread ...st/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparatorTest.java Outdated

Comment thread ...st/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparatorTest.java Outdated

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: changes-required Pull requests that are not yet complete labels Dec 22, 2025

koppor requested changes Dec 22, 2025

View reviewed changes

Comment thread ...st/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparatorTest.java Outdated

koppor reviewed Dec 22, 2025

View reviewed changes

Comment thread jablib/src/main/java/org/jabref/model/entry/Month.java Outdated

HoussemNasri reviewed Dec 22, 2025

View reviewed changes

Comment thread ...c/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java Outdated

HoussemNasri reviewed Dec 22, 2025

View reviewed changes

Comment thread ...c/main/java/org/jabref/logic/bibtex/comparator/plausibility/MonthPlausibilityComparator.java Outdated

D-Prasanth-Kumar closed this Dec 23, 2025

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Jan 2, 2026

D-Prasanth-Kumar requested review from HoussemNasri and koppor January 3, 2026 13:54

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Jan 7, 2026

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Jan 19, 2026

D-Prasanth-Kumar requested a review from calixtus January 20, 2026 17:39

koppor requested changes Jan 22, 2026

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Jan 22, 2026

koppor added this to the 6.0-alpha.6 milestone Jan 23, 2026

D-Prasanth-Kumar force-pushed the task/month-plausibility-comparator branch from c5d8056 to 40ef8cf Compare January 23, 2026 17:57

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Jan 23, 2026

D-Prasanth-Kumar requested a review from koppor January 23, 2026 19:03

koppor mentioned this pull request Jan 24, 2026

Added MonthPlausibilityComparator #14457 #14745

Closed

6 tasks

koppor and others added 3 commits January 24, 2026 07:25

Merge remote-tracking branch 'origin/main' into task/month-plausibili…

f8ae06c

…ty-comparator

converted to markdown and few fixes

262ed72

some fixes

b9c5f86

koppor force-pushed the task/month-plausibility-comparator branch from 0479c71 to b9c5f86 Compare January 24, 2026 06:26

Fix JavaDoc

2b63540

koppor approved these changes Jan 24, 2026

View reviewed changes

koppor enabled auto-merge January 24, 2026 06:29

koppor added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Jan 24, 2026

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Jan 24, 2026

calixtus approved these changes Jan 24, 2026

View reviewed changes

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Jan 24, 2026

koppor added this pull request to the merge queue Jan 24, 2026

koppor mentioned this pull request Jan 24, 2026

Refine comment on git merge conflicts. #14911

Merged

1 task

Merged via the queue into JabRef:main with commit 45f23c8 Jan 24, 2026
57 of 62 checks passed

Uh oh!

Conversation

D-Prasanth-Kumar commented Dec 16, 2025 • edited by qodo-free-for-open-source-projects Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Mandatory checks

Screenshot

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

D-Prasanth-Kumar commented Dec 16, 2025

Uh oh!

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixtus commented Dec 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

D-Prasanth-Kumar commented Dec 23, 2025

Uh oh!

github-actions Bot commented Dec 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koppor commented Jan 22, 2026

Uh oh!

D-Prasanth-Kumar commented Jan 23, 2026

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

D-Prasanth-Kumar commented Dec 16, 2025 •

edited by qodo-free-for-open-source-projects Bot

Loading