Add right-click option to delete custom BST styles for entry preview#14628
Conversation
| }; | ||
|
|
||
| dialogService.notify(message); | ||
| dialogService.notifyAll(message); |
There was a problem hiding this comment.
This is wrong! This is a bug in openrewrite
There was a problem hiding this comment.
I have just pushed a commit that reverts those accidental changes and ensures only the relevant files for this feature (PreviewTab, PreviewTabViewModel, and BstPreviewLayout) are modified. The checkstyle issues in PreviewTab.java should also be resolved now.
| String message = Localization.lang("Error creating email"); | ||
| LOGGER.warn(message, e); | ||
| dialogService.notify(message); | ||
| dialogService.notifyAll(message); |
There was a problem hiding this comment.
revert this is a bug in openrewrite
There was a problem hiding this comment.
Hi @Siedlerchr!
The rewriteDryRun CI check is still failing because OpenRewrite wants to apply automated refactoring across the codebase.
When I run ./gradlew rewriteRun locally, it completes successfully but introduces changes like notify() → notifyAll() (which you mentioned earlier are bugs in OpenRewrite that I should revert).
Should I:
Ignore the failing rewriteDryRun check for now since it's a project-wide issue unrelated to my changes?
There was a problem hiding this comment.
The issue was fixed some months ago - see openrewrite/rewrite-static-analysis#580.
I now don't see any issue here. Not sure what caused it to be solved.
There was a problem hiding this comment.
It seems the tool might still have this issue locally for me. I manually reverted the notifyAll change to fix the build. The PR is now clean and all checks are passing.
…eTriggerx/jabref into feature/remove-custom-bst-v2
|
|
||
| ### Added | ||
|
|
||
| - We added a right-click option to delete custom BST styles in the entry preview. [#14628](https://github.com/JabRef/jabref/pull/14628) |
Closes #14352
Added a context menu option to the "Entry Preview" preferences tab to remove custom BST styles. This allows users to delete styles they have added. I also updated
BstPreviewLayoutto store the file path so the removal persists after a restart.Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)