Skip to content

Add eprinttype field to General Entry editor tab#14620

Merged
calixtus merged 19 commits into
JabRef:mainfrom
prerak09:add-eprinttype-general-tab
Dec 20, 2025
Merged

Add eprinttype field to General Entry editor tab#14620
calixtus merged 19 commits into
JabRef:mainfrom
prerak09:add-eprinttype-general-tab

Conversation

@prerak09

Copy link
Copy Markdown
Contributor

Closes #14555

This pull request adds the eprinttype field to the default General entry editor tab so that it appears alongside eprint, which is where users naturally expect it.
In addition, a preference migration is included to ensure that existing users who still use the old default General tab configuration are updated automatically, while fully respecting any custom tab setups.

Steps to test

  1. Launch JabRef.
  2. Open an existing entry or create a new one.
  3. Open the Entry Editor and navigate to the General tab.
  4. Verify that both eprint and eprinttype fields are visible in the General tab.
  5. i check in my system by running gradle run and checking if eprint is added or not .

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef
  • [/] I added JUnit tests for changes (not applicable for preference/UI configuration changes)
  • I added screenshots in the PR description (change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user
  • [/] I checked the user documentation
image image

@github-actions

Copy link
Copy Markdown
Contributor

Hey @prerak09! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow.

@github-actions github-actions Bot added first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. labels Dec 15, 2025
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 15, 2025

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first step. However, there already is a similar method. Please unify. Comment inline.

Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
@prerak09 prerak09 requested a review from koppor December 15, 2025 11:43
@prerak09

Copy link
Copy Markdown
Contributor Author

@koppor i forgot to remove the comments that i usually do to see what new things i added.
please check once and let me know

@prerak09

prerak09 commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

I unified the migration by extending addICORERankingFieldToGeneralTab
The method now checks for the old default General tab field set and resets to the current defaults, which include both ICORE ranking and eprinttype.
This removes duplicated logic and keeps General tab migrations in one place.
Along with this in new pull request i removed the comments that i kept for my understanding

@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 15, 2025
calixtus
calixtus previously approved these changes Dec 16, 2025
@calixtus calixtus requested a review from Siedlerchr December 16, 2025 23:54
Comment thread CHANGELOG.md Outdated
Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 17, 2025
@prerak09

Copy link
Copy Markdown
Contributor Author

@koppor i changed the method name from icore to migrateGeneralTabDefaultFields now the method migrates the General tab defaults when the user still has an old default setup.

  • i also fixed the changelog link problem .
    and as instructed i read alpha 3 release now we handle both before alpha 3 and after alha 3 release changes
    for that i split the migration function into two cases
    pre and post .

@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 18, 2025
@prerak09 prerak09 requested a review from calixtus December 18, 2025 09:53
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 19, 2025
java docs change to what the method is currently doing
@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 19, 2025
@prerak09 prerak09 requested a review from koppor December 19, 2025 18:35
koppor
koppor previously requested changes Dec 19, 2025
Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 19, 2025
@prerak09 prerak09 requested a review from koppor December 19, 2025 21:42
Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 19, 2025
subhramit
subhramit previously approved these changes Dec 19, 2025
@subhramit subhramit enabled auto-merge December 19, 2025 22:08
@subhramit subhramit added this pull request to the merge queue Dec 19, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Dec 19, 2025
@calixtus calixtus added this pull request to the merge queue Dec 20, 2025
Merged via the queue into JabRef:main with commit 10d4730 Dec 20, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: entry-editor first contrib good first issue An issue intended for project-newcomers. Varies in difficulty.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add eprinttype field to General Entry editor tab

4 participants