feat: add "Close library" to File menu by SatyamKumarCS · Pull Request #14383 · JabRef/jabref

SatyamKumarCS · 2025-11-21T21:55:40Z

This PR adds three new library-management actions to the File menu:

Close library – closes the currently active library.
Close others – closes all libraries except the currently active one.
Close all – closes all open libraries.

Previously, these actions were only available in the library tab’s context menu,
making them harder to discover. Adding them to the File menu improves usability,
aligns with common desktop application UX patterns, and provides faster access
to library management operations.

Steps to test

Start JabRef.
Open multiple libraries (e.g., Library A, Library B, Library C).
Go to File → Close library:
- Only the active library should close.
Go to File → Close others:
- The active library remains open.
- All other libraries close.
Go to File → Close all:
- All open libraries close.
- JabRef returns to the empty state with no libraries open.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
[/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

calixtus

Many unneccessary linebreak changes, please fix before we make a review.

calixtus · 2025-11-21T22:29:21Z

-                       ClipBoardManager clipBoardManager,
-                       TaskExecutor taskExecutor,
-                       GitHandlerRegistry gitHandlerRegistry) {
+    public JabRefFrame(Stage mainStage, DialogService dialogService, FileUpdateMonitor fileUpdateMonitor, GuiPreferences preferences, AiService aiService, StateManager stateManager, CountingUndoManager undoManager, BibEntryTypesManager entryTypesManager, ClipBoardManager clipBoardManager, TaskExecutor taskExecutor, GitHandlerRegistry gitHandlerRegistry) {


Please keep linebreaks

calixtus · 2025-11-21T22:29:31Z

-                undoManager,
-                clipBoardManager,
-                taskExecutor);
+        this.viewModel = new JabRefFrameViewModel(preferences, aiService, stateManager, dialogService, this, this::getOpenDatabaseAction, entryTypesManager, fileUpdateMonitor, undoManager, clipBoardManager, taskExecutor);


Please keep linebreaks

calixtus · 2025-11-21T22:29:47Z

-                mainStage::getScene,
-                this::getOpenDatabaseAction,
-                stateManager);
+        FrameDndHandler frameDndHandler = new FrameDndHandler(tabbedPane, mainStage::getScene, this::getOpenDatabaseAction, stateManager);


Please keep linebreaks

calixtus · 2025-11-21T22:29:50Z

-                undoManager,
-                dialogService,
-                SearchType.NORMAL_SEARCH);
+        this.globalSearchBar = new GlobalSearchBar(this, stateManager, this.preferences, undoManager, dialogService, SearchType.NORMAL_SEARCH);


Please keep linebreaks

calixtus · 2025-11-21T22:29:54Z

                // Actions are recreated here since this avoids passing more parameters and the amount of additional memory consumption is neglegtable.
-                new UndoAction(this::getCurrentLibraryTab, undoManager, dialogService, stateManager),
-                new RedoAction(this::getCurrentLibraryTab, undoManager, dialogService, stateManager));
+                new UndoAction(this::getCurrentLibraryTab, undoManager, dialogService, stateManager), new RedoAction(this::getCurrentLibraryTab, undoManager, dialogService, stateManager));


Please keep linebreaks

calixtus · 2025-11-21T22:32:22Z

-                if (libraryTab != toKeepLibraryTab) {
-                    Platform.runLater(() -> closeTab(libraryTab));
-                }
+            List<LibraryTab> libraryTabs = tabbedPane.getTabs().stream().filter(LibraryTab.class::isInstance).map(LibraryTab.class::cast).filter(tab -> tab != toKeepLibraryTab).toList();


Please introduce linebreaks

calixtus · 2025-11-21T22:38:32Z

+            List<LibraryTab> libraryTabs = tabbedPane.getTabs().stream().filter(LibraryTab.class::isInstance).map(LibraryTab.class::cast).toList();
+            for (LibraryTab tab : libraryTabs) {
+                Platform.runLater(() -> closeTab(tab));


Does this change make reading easier? Because it does not seem to change logic.

calixtus · 2025-11-21T22:41:04Z

    }

-    private class CloseOthersDatabaseAction extends SimpleCommand {
+    public class CloseOthersDatabaseAction extends SimpleCommand {


static protected?

calixtus · 2025-11-21T22:50:47Z

+                    {
+                        this.executable.bind(Bindings.createBooleanBinding(
+                                () -> ActionHelper.needsMultipleDatabases(stateManager).get() && frame.getCurrentLibraryTab() != null,
+                                stateManager.getOpenDatabases(), stateManager.activeTabProperty()));
+                    }
+
+                    @Override
+                    public void execute() {
+                        LibraryTab currentTab = frame.getCurrentLibraryTab();
+                        if (currentTab != null) {
+                            frame.new CloseOthersDatabaseAction(currentTab).execute();
+                        }
+                    }
+                }),


Please extract

calixtus · 2025-11-21T22:51:14Z

+                    {
+                        this.executable.bind(ActionHelper.needsDatabase(stateManager));
+                    }
+
+                    @Override
+                    public void execute() {
+                        frame.new CloseAllDatabaseAction().execute();
+                    }


Please extract

calixtus · 2025-11-22T19:29:56Z

-                       ClipBoardManager clipBoardManager,
-                       TaskExecutor taskExecutor,
-                       GitHandlerRegistry gitHandlerRegistry) {
+    @SuppressWarnings("checkstyle:EmptyLineSeparator")


koppor

The issue did not ask for more. Close others can go to the tab context menu; Close all takes too much space (and is used very seldomly). Please remove it

Try to keep the code formatted as is. Use IntellIj IDE to train your (!) development skills.

SatyamKumarCS · 2025-11-23T11:44:37Z

Oh. I've now made the changes.

calixtus · 2025-11-23T11:46:43Z

Please take a look at https://github.com/JabRef/jabref/pull/14383/files to see where unneccessary linebreaks were added.

SatyamKumarCS · 2025-11-23T11:57:36Z

Hi, @calixtus! Thanks for the review.
Previously, I had added the line breaks as requested, but I’m having trouble identifying which extra or unnecessary line breaks I introduced. Could you please point me to the exact part of the file or the specific lines where the issue occurs? This will help me take corrective measures.

Thanks again for your guidance!

calixtus · 2025-11-23T12:04:01Z

See https://github.com/JabRef/jabref/pull/14383/files

SatyamKumarCS · 2025-11-23T19:33:03Z

@calixtus @koppor Please check now, I have made all the changes requested.

koppor

Files are still reformatted without reason.

Please check https://github.com/JabRef/jabref/pull/14383/files and ensure that there are only semantic changes; and not only syntactic ones

koppor · 2025-11-23T19:42:47Z

-        this.viewModel = new JabRefFrameViewModel(
-                preferences,
+        this.viewModel = new JabRefFrameViewModel(preferences,


Why the reformat?

koppor · 2025-11-23T19:42:49Z

-                       GitHandlerRegistry gitHandlerRegistry) {
+                       GitHandlerRegistry gitHandlerRegistry
+    ) {


Why the reformat?

koppor · 2025-11-23T19:42:55Z

                clipBoardManager,
-                taskExecutor);
+                taskExecutor
+        );
        Injector.setModelOrService(UiMessageHandler.class, viewModel);


Why the reformat?

koppor · 2025-11-23T19:43:02Z

-        FrameDndHandler frameDndHandler = new FrameDndHandler(
-                tabbedPane,
+        FrameDndHandler frameDndHandler = new FrameDndHandler(tabbedPane,


Why the reformat?

koppor · 2025-11-23T19:43:07Z

-                stateManager);
+                stateManager
+        );


Why the reformat?

koppor · 2025-11-23T19:43:14Z

-        this.globalSearchBar = new GlobalSearchBar(
-                this,
+        this.globalSearchBar = new GlobalSearchBar(this,


Why the reformat?

koppor · 2025-11-23T19:43:20Z

-                SearchType.NORMAL_SEARCH);
+                SearchType.NORMAL_SEARCH
+        );


Why the reformat?

koppor · 2025-11-23T19:44:52Z

@calixtus @koppor Please check now, I have made all the changes requested.

No. Please respect our wishes that we want to have semantic changes only; not just syntactic changes.

calixtus · 2025-11-23T20:20:35Z

Did the reformat quickly myself, but kept (and added) some reasonable changes, where the lines exceeded way over average line length.

Actual change looks good though.

jabref-machine · 2025-11-23T20:41:23Z

You ticked that you modified CHANGELOG.md, but no new entry was found there.

If you made changes that are visible to the user, please add a brief description along with the issue number to the CHANGELOG.md file. If you did not, please replace the cross ([x]) by a slash ([/]) to indicate that no CHANGELOG.md entry is necessary. More details can be found in our Developer Documentation about the changelog.

Implemented changes.

SatyamKumarCS added 2 commits November 22, 2025 03:17

feat: add "Close library" to File menu

5f34af0

fix: format issues in file menu

bf4a50c

calixtus previously requested changes Nov 21, 2025

View reviewed changes

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: changes-required Pull requests that are not yet complete labels Nov 21, 2025

SatyamKumarCS requested a review from calixtus November 22, 2025 07:28

chore(format): format code for better readability

77c3e22

SatyamKumarCS force-pushed the feat/closeLib branch from d20f9c2 to 77c3e22 Compare November 22, 2025 07:40

SatyamKumarCS added 2 commits November 22, 2025 13:13

chore(format): format code

501f26a

Merge branch 'main' into feat/closeLib

bad81b7

calixtus reviewed Nov 22, 2025

View reviewed changes

fix: missed @Suppress

8e3213c

SatyamKumarCS requested a review from calixtus November 22, 2025 19:36

koppor requested changes Nov 23, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

fix: remove close all

e32d027

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

SatyamKumarCS requested a review from koppor November 23, 2025 11:44

SatyamKumarCS added 2 commits November 23, 2025 23:11

Merge branch 'main' into feat/closeLib

9a5c019

chore(format): fix missing linebreaks

fe68578

koppor requested changes Nov 23, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

Undo linebreaks

f63031b

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

Undo linebreaks

cbc1abb

koppor added 2 commits November 23, 2025 21:32

Add CHANGELOG.md entry

5123a7c

Remove obsolete separator

486ff01

koppor previously approved these changes Nov 23, 2025

View reviewed changes

koppor enabled auto-merge November 23, 2025 20:40

koppor dismissed their stale review via 486ff01 November 23, 2025 20:40

koppor approved these changes Nov 23, 2025

View reviewed changes

koppor added this pull request to the merge queue Nov 23, 2025

Merged via the queue into JabRef:main with commit 92cc09d Nov 23, 2025
49 of 50 checks passed

github-actions Bot mentioned this pull request Nov 23, 2025

Add "Close library" to menu #14381

Closed

Uh oh!

Conversation

SatyamKumarCS commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

SatyamKumarCS commented Nov 23, 2025

Uh oh!

calixtus commented Nov 23, 2025

Uh oh!

SatyamKumarCS commented Nov 23, 2025

Uh oh!

calixtus commented Nov 23, 2025

Uh oh!

SatyamKumarCS commented Nov 23, 2025

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor commented Nov 23, 2025

Uh oh!

calixtus commented Nov 23, 2025

Uh oh!

jabref-machine commented Nov 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SatyamKumarCS commented Nov 21, 2025 •

edited

Loading