Add follow-up questions feature to AI chat by Muskan244 · Pull Request #14354 · JabRef/jabref

Muskan244 · 2025-11-19T15:17:58Z

This PR implements a follow-up questions feature to AI chat. After the AI responds to a user's question, the system automatically generates 3-5 relevant follow-up questions that appear as clickable links below the chat.
Changes:

Added new "Generate follow-up questions" setting in AI preferences
Created FollowUpQuestionGenerator class to generate questions via AI
Integrated follow-up generation into AiChatLogic after each AI response
Added UI component to display clickable follow-up question links
Questions are cleared when any new message is sent

Steps to test

Go to Preferences → AI, enable AI with API key, and check "Generate follow-up questions"
Open an entry with a PDF attached and click the "AI chat" tab
Send a question and verify that 3-5 clickable follow-up questions appear below the chat
Click a follow-up question and verify it sends automatically and new questions appear
Disable the setting in preferences and verify no follow-up questions appear

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Implement automatic generation of follow-up questions after AI responses in the chat interface. Users can click suggested questions to continue the conversation naturally. Changes: - Add Generate follow-up questions setting in AI preferences - Create FollowUpQuestionGenerator to generate questions via AI - Update AiChatLogic to generate questions after each response - Display clickable follow-up question links in chat UI - Clear questions when new message is sent

Implement automatic generation of follow-up questions after AI responses in the chat interface. Users can click suggested questions to continue the conversation naturally. Changes: - Add Generate follow-up questions setting in AI preferences - Create FollowUpQuestionGenerator to generate questions via AI - Update AiChatLogic to generate questions after each response - Display clickable follow-up question links in chat UI - Clear questions when new message is sent # Conflicts: # jablib/src/main/resources/csl-styles

…bref into fix-for-issue-12243

ThiloteE · 2025-11-20T21:33:13Z

Things I would like you to address in this PR:
I tried generating follow up questions and it simply works. Great job!
Only one tiny thing is amiss: I think you should limit the number of follw up questions to three (or maybe add a preference that lets users choose the number and set the default to three). As you can see the questions may be too long for the GUI:
Possible follow up PR:
Since we have a user base that does not only speak English, it would be good to expose this instruction as a template in the AI preferences, so that every user can manually translate this instruction to their own language, Here:

Maybe far in the future, we can make it dependent on the set user language, but that's a long shot.

InAnYan · 2025-11-21T15:13:43Z

What would anyone think about this:

I think there are too many buttons for questions. What if we could hide "Try these examples" as soon as there are follow up questions?

InAnYan · 2025-11-21T15:20:43Z

Okay, good! But the follow up questions template must be an AiTemplate

Muskan244 · 2025-11-21T16:09:08Z

Things I would like you to address in this PR:
I tried generating follow up questions and it simply works. Great job!
Only one tiny thing is amiss: I think you should limit the number of follw up questions to three (or maybe add a preference that lets users choose the number and set the default to three). As you can see the questions may be too long for the GUI:

I will limit the number of generated follow-up questions to three by default and will try to add the preference for users too.

2. Possible follow up PR:
Since we have a user base that does not only speak English, it would be good to expose this instruction as a template in the AI preferences, so that every user can manually translate this instruction to their own language, Here:

I would be happy to look into adding this in a follow-up PR.

Muskan244 · 2025-11-21T16:24:35Z

Okay, good! But the follow up questions template must be an AiTemplate

Thanks, I will update the follow-up questions to use an AiTemplate instead of the current inline string.

…mplate - Default follow-up questions at 3 - New user preference to configure maximum number - Converted prompt to AiTemplate for consistency

…bref into fix-for-issue-12243

Muskan244 · 2025-11-21T19:44:38Z

I have implemented these changes:

Limited the number of generated follow-up questions to three by default
Added a user preference to customize this limit
Converted the follow-up questions instruction into an AiTemplate

What would anyone think about this:

I think there are too many buttons for questions. What if we could hide "Try these examples" as soon as there are follow up questions?

I have not worked on this part yet. If you would like me to include it in this PR, please let me know and I will be happy to update it.

InAnYan · 2025-11-23T11:31:40Z

Isn't there a JavaFX element for increasing and decreasing numbers?

Should we add "Automatically" at the new bullet point? - To be consistent to the other two settings?

Replying to @koppor .

I think Automatically doesn't make sense. The reason why I introduced previous 2 options is because before one should've manually click "Generate summary" or "Embeddings".

Generation of follow-up questions already implies that they are generated automatically.

Though... maybe I was wrong with the wording "Automatically generate embeddings". Need to dive more

InAnYan · 2025-11-23T11:33:26Z

I tested more, and found that hover is also available. Cool!

Muskan244 · 2025-11-23T14:27:26Z

And when there are follow-up questions, can you hide the HBox with example questions?

I just want to clarify whether this should be done in this PR or in a separate PR, because @koppor commented earlier:

I think there are too many buttons for questions. What if we could hide "Try these examples" as soon as there are follow up questions?

I have not worked on this part yet. If you would like me to include it in this PR, please let me know and I will be happy to update it.

Very OK for me to do that in a separate PR.

If I am mixing up two different things, please let me know.

InAnYan · 2025-11-23T15:00:13Z

Ah, sorry, now I understand your confusion.

But, IMHO, the review comments that are left are one-liners, so I think it's not hard to incorporate them in this PR

Muskan244 · 2025-11-23T20:16:00Z

Ah, sorry, now I understand your confusion.

But, IMHO, the review comments that are left are one-liners, so I think it's not hard to incorporate them in this PR

Thanks for the clarification. I'll add it in this PR.

koppor · 2025-11-23T20:44:21Z

I have not worked on this part yet. If you would like me to include it in this PR, please let me know and I will be happy to update it.
Very OK for me to do that in a separate PR.
If I am mixing up two different things, please let me know.

I mis-read your question. Please include it here.

- Remove Automatically from the follow-up questions setting - Disable numeric input and gray label when the checkbox is unchecked - Fix the reset template button - Add colons to Try with examples and Follow-up questions - Hide example questions HBox when follow-up questions are visible

…bref into fix-for-issue-12243

Muskan244 · 2025-11-23T21:13:17Z

I have implemented these changes:

Removed “Automatically” and now it is “Generate follow-up questions”
Disabled the number input and grayed out the label when the checkbox is unchecked
Fixed the “Reset current template" button for follow-up questions
Added colons to “Try with examples:” and “Follow-up questions:”
Hid the example questions HBox when follow-up questions are displayed

Let me know if anything else is needed!

koppor

During generation, the "try with examples" are still shown. Why? -- I think, it should not.

Muskan244 · 2025-11-24T06:37:07Z

During generation, the "try with examples" are still shown. Why? -- I think, it should not.

Thanks for pointing it out, currently I hide “Try with examples” only when follow-up questions are displayed. When a new message is sent, the follow-up list is cleared in preparation for generating new ones, so the examples reappear during generation.
I’ll update the logic so that “Try with examples” stays hidden while the model is generating follow-up questions as well.

JabRef#14354 (comment)

Fixed by us.

Muskan244 added 9 commits November 19, 2025 19:26

Add CHANGELOG.md entry

c86fd77

Add CHANGELOG.md entry

e822313

Merge branch 'fix-for-issue-12243' of https://github.com/Muskan244/ja…

010e33d

…bref into fix-for-issue-12243

Fix submodules, CHANGELOG.md and overwrite issues

6f17bb1

Fixed issues in rewritten files to match original files

604f44d

Fix submodules modified test

49ac25e

Fix format indentation

f368e18

koppor requested review from InAnYan and ThiloteE November 20, 2025 10:40

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 20, 2025

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into fix-for-issue-12243

ee8b971

InAnYan requested changes Nov 21, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread jablib/src/main/java/org/jabref/logic/ai/AiDefaultPreferences.java Outdated

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 21, 2025

Muskan244 added 2 commits November 22, 2025 00:26

Add preference for max follow-up questions and migrate prompt to AiTe…

45d6dbb

…mplate - Default follow-up questions at 3 - New user preference to configure maximum number - Converted prompt to AiTemplate for consistency

Merge branch 'fix-for-issue-12243' of https://github.com/Muskan244/ja…

338d91e

…bref into fix-for-issue-12243

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Nov 21, 2025

Merge branch 'main' into fix-for-issue-12243

97709ff

Muskan244 added 2 commits November 24, 2025 02:16

Merge branch 'fix-for-issue-12243' of https://github.com/Muskan244/ja…

d72d9ca

…bref into fix-for-issue-12243

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

koppor requested changes Nov 23, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Nov 23, 2025

Hide Try with examples also during follow-up question generation

0607394

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Nov 24, 2025

Merge branch 'main' into fix-for-issue-12243

5c5a491

koppor previously approved these changes Nov 24, 2025

View reviewed changes

Add Ruslans proposal

5e526b7

JabRef#14354 (comment)

koppor dismissed their stale review via 5e526b7 November 24, 2025 20:34

koppor previously approved these changes Nov 24, 2025

View reviewed changes

koppor enabled auto-merge November 24, 2025 20:49

Enable follow-up questions as default

8a8020b

koppor dismissed their stale review via 8a8020b November 24, 2025 20:51

subhramit approved these changes Nov 24, 2025

View reviewed changes

koppor approved these changes Nov 24, 2025

View reviewed changes

koppor added this pull request to the merge queue Nov 24, 2025

Merged via the queue into JabRef:main with commit 0a9793a Nov 24, 2025
51 checks passed

github-actions Bot mentioned this pull request Nov 24, 2025

Follow-up questions in AI chat #12243

Closed

Uh oh!

Conversation

Muskan244 commented Nov 19, 2025

Steps to test

Mandatory checks

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

ThiloteE commented Nov 20, 2025

Uh oh!

InAnYan commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

InAnYan commented Nov 21, 2025

Uh oh!

Muskan244 commented Nov 21, 2025

Uh oh!

Muskan244 commented Nov 21, 2025

Uh oh!

Muskan244 commented Nov 21, 2025

Uh oh!

InAnYan commented Nov 23, 2025

Uh oh!

InAnYan commented Nov 23, 2025

Uh oh!

Muskan244 commented Nov 23, 2025

Uh oh!

InAnYan commented Nov 23, 2025

Uh oh!

Muskan244 commented Nov 23, 2025

Uh oh!

koppor commented Nov 23, 2025

Uh oh!

Muskan244 commented Nov 23, 2025

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Muskan244 commented Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants