Add support for searching csl preview styles by short title#13728

Merged

Siedlerchr merged 4 commits into

mainfrom

Aug 22, 2025

Siedlerchr commented Aug 21, 2025 •

edited

Loading

Member

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/1026
Make @InAnYan happy :)

Steps to test

Delete gradle config cache
Regenerate citation catalog json
Run jabref and search for apa in preview -> style is found

Mandatory checks

grafik

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
[x[ Screenshots added in PR description (if change is visible to the user)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr added 2 commits

August 21, 2025 21:28


          Add support for searching csl preview styles by short title

803f1f5


          changelog

4831b8d

Siedlerchr added the status: ready-for-review label

trag-bot Bot reviewed

View reviewed changes

build-support/src/test/java/CitationStyleCatalogGeneratorTest.java


          checkstyle

59f6460

trag-bot Bot reviewed

View reviewed changes

jablib/src/test/java/org/jabref/logic/citationstyle/CSLStyleUtilsTest.java

trag-bot Bot reviewed

View reviewed changes

jablib/src/main/java/org/jabref/logic/citationstyle/CitationStylePreviewLayout.java

trag-bot Bot reviewed

View reviewed changes

jablib/src/main/java/org/jabref/logic/layout/TextBasedPreviewLayout.java

trag-bot Bot reviewed

View reviewed changes

jablib/src/test/java/org/jabref/logic/citationstyle/CSLStyleUtilsTest.java

Siedlerchr commented Aug 21, 2025 •

edited

Loading

Member Author

Ah my submodule was not updated correctly


          chicago on https://github.com/citation-style-language/styles/blob/119…

e33f9a4

…4364e8538628a6316a7a84f74e383cd9f4f49/chicago-author-date.csl is newer

trag-bot Bot commented Aug 21, 2025

@trag-bot didn't find any issues in the code! ✅✨

InAnYan approved these changes

View reviewed changes

InAnYan left a comment

Member

Cool! Didn't think that this would be that easy to solve

Siedlerchr added this pull request to the merge queue

Merged via the queue into main with commit 1cdbcfa

2 checks passed

Siedlerchr deleted the shorttitlecsl branch

August 22, 2025 06:35

InAnYan commented Aug 22, 2025

Member

Doh, it's optional! But in code it's required always

InAnYan mentioned this pull request

fix(csl): allow short title to be nullable #13733

Closed

3 tasks

koppor mentioned this pull request

Add backwards compatibililty for citation style cache #13734

Merged

2 tasks

Siedlerchr commented Aug 22, 2025

Member Author

Yes it's optional but if not found it's empty

koppor commented Aug 22, 2025

Member

Yes it's optional but if not found it's empty

The issue is of no gradlew clean is called.

Siedlerchr commented Aug 22, 2025

Member Author

jabref/jablib/build.gradle.kts

Line 262 in 00fc407

onlyIf {!cslCatalogJson.get().asFile.exists()}

because of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review