Skip to content

Add additional hint#13641

Merged
koppor merged 1 commit into
mainfrom
refine-howto
Aug 11, 2025
Merged

Add additional hint#13641
koppor merged 1 commit into
mainfrom
refine-howto

Conversation

@koppor

@koppor koppor commented Aug 3, 2025

Copy link
Copy Markdown
Member

Follow-up to #13632

Our gradle update workflow (https://github.com/JabRef/jabref/blob/main/.github/workflows/update-gradle-wrapper.yml) cannot update devcontainer gradle version.

Therefore, we need a manual check.

Other options:

  • Create an issue in our repository as soon as gradle is updated
  • Try with regex magic to update the gradle version in devcontainer.json after a gradle update. (can be a good AI task)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot

trag-bot Bot commented Aug 3, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor requested a review from Siedlerchr August 3, 2025 13:42
@Siedlerchr

Copy link
Copy Markdown
Member

I am not even sure if we need gradle in the devcontainer, it was just trying out if junie can build with it

@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 11, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 11, 2025
@koppor koppor merged commit afdee30 into main Aug 11, 2025
2 checks passed
@koppor koppor deleted the refine-howto branch August 11, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants