fix:Libre office reference extension after adding spaces. by tushar-2320 · Pull Request #13592 · JabRef/jabref

tushar-2320 · 2025-07-27T05:00:01Z

Closes #13559

I have added Add space after citation in settings of open office panel.
screen recording of it is as follows.

Screen.Recording.2025-08-06.at.11.18.19.AM.mp4

so now by selecting checkbox we get space after citation.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (if change is visible to the user)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

subhramit · 2025-07-27T08:04:24Z

Please provide an appropriate name and description to your PR, even if draft.

subhramit · 2025-08-01T12:19:52Z

Hey, let me know if you need any help continuing this.

tushar-2320 · 2025-08-02T14:00:48Z

Hey I got preferences but i am not able to understand flow how do change the Boolean value from settings @subhramit

subhramit · 2025-08-02T15:57:26Z

Hey I got preferences but i am not able to understand flow how do change the Boolean value from settings @subhramit

See how the first setting in the screenshot in the issue is set (automatically sync bibliography) for example. That's also a boolean, right?

tushar-2320 · 2025-08-03T07:16:56Z

hey @subhramit just check wether I am in right direction or not?

subhramit · 2025-08-03T12:02:07Z

        CheckMenuItem autoSync = new CheckMenuItem(Localization.lang("Automatically sync bibliography when inserting citations"));
        autoSync.selectedProperty().set(openOfficePreferences.getSyncWhenCiting());

+        CheckMenuItem smartSpace = new CheckMenuItem(Localization.lang("Add smart space after citation"));


The space we add before citations are called "smart" because they are aware of if a space already exists.
For the space after, we are just adding it if an option is manually enabled, so change this to 'add space after citations"

subhramit · 2025-08-03T12:02:52Z

    private final StringProperty cslBibliographyHeaderFormat;
    private final StringProperty cslBibliographyBodyFormat;
    private final ObservableList<String> externalCslStyles;
+    private final BooleanProperty smartSpaceAfter;


Have to rename all these variables and methods due to above explanation.

subhramit · 2025-08-03T12:04:08Z

    public static final String OO_CSL_BIBLIOGRAPHY_HEADER_FORMAT = "cslBibliographyHeaderFormat";
    public static final String OO_CSL_BIBLIOGRAPHY_BODY_FORMAT = "cslBibliographyBodyFormat";
-
+    public static final String OO_SMART_SPACE_AFTER = "ooSmartSpaceAfter";


Rename everywhere

subhramit

Hi, i have left some initial comments. Your direction of playing around with preferences and properties is correct, but somehow the changes to CSLCitationooadapter seem to be lost. So you have to use this property in the functions there from preferences henceforth.

tushar-panto · 2025-08-04T04:32:47Z

I tried to make changes around CSLCitationooadapter property just check it is this how its done @subhramit .?

subhramit · 2025-08-04T05:08:14Z

I tried to make changes around CSLCitationooadapter property just check it is this how its done @subhramit .?

Unfortunately, that's not the right way. I get your thought process, but you had to use preferences, not ~~the injector~~ injection via constructor. See, for example, how the current style is obtained in the class from preferences. Since preferences are already imported and initialized in the class, why not use them?

PS - if this explanation is unclear, please do ask for more clarification. The reason I'm not giving you the solution right away is so that you learn something when navigating the codebase as well.
When following an example, try to understand what it is doing rather than just making an equivalent copy-paste.

tushar-2320 · 2025-08-05T06:32:59Z

now can you check @subhramit ?

subhramit

Few comments on correctness.
After you are done with these, add a changelog entry, move the PR away from draft, mark the mandatory checks, write a description and post a short screen recording of the changes.

subhramit · 2025-08-05T08:46:43Z


    private CitationStyle currentStyle;
    private boolean styleChanged;
+    private boolean addSpaceAfter;


subhramit · 2025-08-05T08:46:50Z


        OOStyle initialStyle = openOfficePreferences.getCurrentStyle(); // may be a jstyle, can still be used for detecting subsequent style changes in context of CSL
-
+        this.addSpaceAfter = openOfficePreferences.getAddSpaceAfter();


subhramit · 2025-08-05T08:47:54Z

        }
-
-        markManager.insertReferenceIntoOO(entries, document, cursor, ooText, !preceedingSpaceExists, false);
+        markManager.insertReferenceIntoOO(entries, document, cursor, ooText, !preceedingSpaceExists, addSpaceAfter);


Use this

Suggested change

markManager.insertReferenceIntoOO(entries, document, cursor, ooText, !preceedingSpaceExists, addSpaceAfter);

markManager.insertReferenceIntoOO(entries, document, cursor, ooText, !preceedingSpaceExists, openOfficePreferences.getAddSpaceAfter());

Reason: The setting may have changed after the instantiation of the adapter.

subhramit · 2025-08-05T08:50:41Z

        CheckMenuItem autoSync = new CheckMenuItem(Localization.lang("Automatically sync bibliography when inserting citations"));
        autoSync.selectedProperty().set(openOfficePreferences.getSyncWhenCiting());

+        CheckMenuItem addSpaceAfter = new CheckMenuItem(Localization.lang("Add  space after citation"));


Suggested change

CheckMenuItem addSpaceAfter = new CheckMenuItem(Localization.lang("Add space after citation"));

CheckMenuItem addSpaceAfter = new CheckMenuItem(Localization.lang("Add space after citation"));

Also, add the keys to the localization JabRef_en.properties file (see the failing check).

… to localization.

subhramit · 2025-08-05T10:53:55Z


 Automatically\ add\ "Cited\ on\ pages..."\ at\ the\ end\ of\ bibliographic\ entries=Automatically add "Cited on pages..." at the end of bibliographic entries
 Automatically\ sync\ bibliography\ when\ inserting\ citations=Automatically sync bibliography when inserting citations
+"Add\ space\ after\ citation"=Add  space after citation


Why the extra space above and here? You can click commit suggestion in https://github.com/JabRef/jabref/pull/13592/files#r2253606699 and below:

Suggested change

"Add\ space\ after\ citation"=Add space after citation

"Add\ space\ after\ citation"=Add space after citation

subhramit · 2025-08-06T03:58:49Z


 Automatically\ add\ "Cited\ on\ pages..."\ at\ the\ end\ of\ bibliographic\ entries=Automatically add "Cited on pages..." at the end of bibliographic entries
 Automatically\ sync\ bibliography\ when\ inserting\ citations=Automatically sync bibliography when inserting citations
+"Add\ space\ after\ citation"=Add space after citation


Please look at 1. Other example entries. And/or 2. Failing checks by clicking on them to get hints as to which tests are failing. The bot comments already instruct on this.

In this case, you have to remove the quotes. There should be no quotes, unless they are a part of the string itself.

Suggested change

"Add\ space\ after\ citation"=Add space after citation

Add\ space\ after\ citation=Add space after citation

tushar-2320 · 2025-08-06T06:02:36Z

@subhramit can you check screen recording?

subhramit · 2025-08-06T07:03:10Z

@subhramit can you check screen recording?

Yep, that's correct. I tried out myself, works properly.

Mow please add a changelog entry and mark the pr non-draft (ready for review).

subhramit

I refined the changelog entry a bit, rest lgtm

trag-bot · 2025-08-07T17:33:11Z

@trag-bot didn't find any issues in the code! ✅✨

tushar-2320 · 2025-08-08T04:32:54Z

Thank you @subhramit for guiding me.

intial commit.

d640769

tushar-2320 marked this pull request as draft July 27, 2025 05:01

tushar-2320 changed the title ~~intial commit.~~ fix:Libre office reference extension after adding spaces. Jul 27, 2025

fix:Added smart space in setting for open office.

f290a70

refactor:refactored naming conventions.

059b5f7

subhramit reviewed Aug 3, 2025

View reviewed changes

fix:fix a bug.

4fac166

subhramit reviewed Aug 3, 2025

View reviewed changes

subhramit requested changes Aug 3, 2025

View reviewed changes

tushar-2320 added 2 commits August 3, 2025 17:44

fix:renamed from smartspaceafter to addspaceafter

0fec031

fix:added changes in CSLCitationOOAdapter.

a6e54e5

fix : changed spaces values via office preferences.

f5e95a8

subhramit requested changes Aug 5, 2025

View reviewed changes

subhramit reviewed Aug 5, 2025

View reviewed changes

Refactor:refactored to use setAfterspace to use directly and add keys…

c221603

… to localization.

subhramit reviewed Aug 5, 2025

View reviewed changes

tushar-2320 added 2 commits August 6, 2025 08:39

fix:extra space.

dd5f74d

Merge remote-tracking branch 'origin/main' into fix-for-issue-13559

4d99316

subhramit requested changes Aug 6, 2025

View reviewed changes

fix:removed quotes

4b94db8

tushar-2320 added 2 commits August 6, 2025 13:53

CHANGELOG.md:Added changes to it.

d035551

CHANGELOG.md:Added changes to it.

6a4aba2

tushar-2320 marked this pull request as ready for review August 6, 2025 08:43

subhramit reviewed Aug 6, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

Update CHANGELOG.md

a722c97

subhramit previously approved these changes Aug 6, 2025

View reviewed changes

subhramit requested a review from Siedlerchr August 6, 2025 09:24

subhramit added component: libre-office component: preferences status: awaiting-second-review For non-trivial changes labels Aug 6, 2025

subhramit and others added 3 commits August 6, 2025 15:00

Merge branch 'main' into fix-for-issue-13559

cede807

Merge branch 'main' into fix-for-issue-13559

fe2aa7e

Refine changelog

851cc40

subhramit dismissed their stale review via 851cc40 August 7, 2025 17:31

subhramit approved these changes Aug 7, 2025

View reviewed changes

subhramit enabled auto-merge August 7, 2025 17:32

subhramit added this pull request to the merge queue Aug 7, 2025

Merged via the queue into JabRef:main with commit 197bc13 Aug 7, 2025
1 check passed

github-actions Bot mentioned this pull request Aug 7, 2025

LibreOffice Writer and JabRef #13559

Closed

2 tasks


		OOStyle initialStyle = openOfficePreferences.getCurrentStyle(); // may be a jstyle, can still be used for detecting subsequent style changes in context of CSL

		this.addSpaceAfter = openOfficePreferences.getAddSpaceAfter();

	markManager.insertReferenceIntoOO(entries, document, cursor, ooText, !preceedingSpaceExists, addSpaceAfter);
	markManager.insertReferenceIntoOO(entries, document, cursor, ooText, !preceedingSpaceExists, openOfficePreferences.getAddSpaceAfter());

	CheckMenuItem addSpaceAfter = new CheckMenuItem(Localization.lang("Add space after citation"));
	CheckMenuItem addSpaceAfter = new CheckMenuItem(Localization.lang("Add space after citation"));

	"Add\ space\ after\ citation"=Add space after citation
	"Add\ space\ after\ citation"=Add space after citation

	"Add\ space\ after\ citation"=Add space after citation
	Add\ space\ after\ citation=Add space after citation

Uh oh!

Conversation

tushar-2320 commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

subhramit commented Jul 27, 2025

Uh oh!

subhramit commented Aug 1, 2025

Uh oh!

tushar-2320 commented Aug 2, 2025

Uh oh!

subhramit commented Aug 2, 2025

Uh oh!

tushar-2320 commented Aug 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

subhramit left a comment

Choose a reason for hiding this comment

Uh oh!

tushar-panto commented Aug 4, 2025

Uh oh!

subhramit commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tushar-2320 commented Aug 5, 2025

Uh oh!

subhramit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tushar-2320 commented Aug 6, 2025

Uh oh!

subhramit commented Aug 6, 2025

Uh oh!

Uh oh!

subhramit left a comment

Choose a reason for hiding this comment

Uh oh!

trag-bot Bot commented Aug 7, 2025

Uh oh!

Uh oh!

tushar-2320 commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tushar-2320 commented Jul 27, 2025 •

edited

Loading

subhramit commented Aug 4, 2025 •

edited

Loading