Skip to content

Add monthfiled to resolve strings fields#13379

Merged
Siedlerchr merged 9 commits into
mainfrom
addMonthfield
Jun 21, 2025
Merged

Add monthfiled to resolve strings fields#13379
Siedlerchr merged 9 commits into
mainfrom
addMonthfield

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jun 19, 2025

Copy link
Copy Markdown
Member

Fixes #13375

Steps to test

Open JabRef settings -> Entry -> Resolve strings for -> montfiled is present

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/ Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 19, 2025
Comment thread CHANGELOG.md
@koppor

koppor commented Jun 19, 2025

Copy link
Copy Markdown
Member

One more thing: Isnt monthfield an alias for month? Isn't it then an issue regarding aliassed fields?

Comment thread jabgui/src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated
Comment thread jabgui/src/test/java/org/jabref/migrations/GuiPreferencesMigrationsTest.java Outdated
@koppor

koppor commented Jun 19, 2025

Copy link
Copy Markdown
Member

One more thing: Isnt monthfield an alias for month? Isn't it then an issue regarding aliassed fields?

OMG, its filed; not field. Thus, no alias

@Siedlerchr

Copy link
Copy Markdown
Member Author

One more thing: Isnt monthfield an alias for month? Isn't it then an issue regarding aliassed fields?

OMG, its filed; not field. Thus, no alias

Yes! That's a tricky one. Had to carefully read the issue... 😆

@Siedlerchr Siedlerchr enabled auto-merge June 19, 2025 16:22

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With nice preference migration. Thank you!

I removed duplicate "mothfiled" in 4f1e64a (#13379)

@trag-bot

trag-bot Bot commented Jun 21, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 21, 2025
Merged via the queue into main with commit c662e48 Jun 21, 2025
2 checks passed
@Siedlerchr Siedlerchr deleted the addMonthfield branch June 21, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

monthfiled formatted incorrectly in the BibTeX source

2 participants