Skip to content

Update PULL_REQUEST_TEMPLATE.md#13188

Merged
koppor merged 1 commit into
mainfrom
koppor-patch-2
May 31, 2025
Merged

Update PULL_REQUEST_TEMPLATE.md#13188
koppor merged 1 commit into
mainfrom
koppor-patch-2

Conversation

@koppor

@koppor koppor commented May 30, 2025

Copy link
Copy Markdown
Member

GitHub app on the mobile phone always displsays <!-- YOU HAVE TO ... as preview text. I think, I cannot convince GitHub to update their app to "correctly" render the PR text.

I think, adding "PLEASE DELETE THIS TEXT" is not a good instruction.

Thus, I propose to re-order the text in the PR template.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor requested a review from subhramit May 30, 2025 10:28
@trag-bot

trag-bot Bot commented May 30, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@subhramit

subhramit commented May 30, 2025

Copy link
Copy Markdown
Member

GitHub app on the mobile phone always displsays <!-- YOU HAVE TO ... as preview text.

Although I have not faced this on my mobile app, the restructuring looks good

@koppor koppor marked this pull request as ready for review May 30, 2025 18:39
@trag-bot

trag-bot Bot commented May 30, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added this pull request to the merge queue May 31, 2025
Merged via the queue into main with commit 219d198 May 31, 2025
2 checks passed
@koppor koppor deleted the koppor-patch-2 branch May 31, 2025 07:59
@koppor koppor mentioned this pull request Jun 15, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants