Add progess output for consisteny check#13181
Conversation
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
left a comment
There was a problem hiding this comment.
Minor comment on CLI output
other than that: LGTM (did not try the UI)
| BibliographyConsistencyCheck consistencyCheck = new BibliographyConsistencyCheck(); | ||
| BibliographyConsistencyCheck.Result result = consistencyCheck.check(entries); | ||
| BibliographyConsistencyCheck.Result result = consistencyCheck.check(entries, (count, total) -> { | ||
| System.out.println(Localization.lang("Checking consistency for entry type %0 of %1", count + 1, total)); |
There was a problem hiding this comment.
Should only happen, if --porcelain is NOT active.
There was a problem hiding this comment.
Forgot to push or is the check somewhere else? 😅
There was a problem hiding this comment.
Is there a project or todo list on github we can use to type and save pending things that are not "issues" or PRs (for that we have maintainer's focus)? a lot of times follow-up requests in comments can be lost in history
BTW - sorry for premature merge
There was a problem hiding this comment.
We collect this in the melting pot to keep the number of boards low 😅
Otherwise, it could be added to "maintainers focus" but it will get lost there maybe 😅
|
Apart from olly's comment LGTM too |
Fixes #12487
Supersedes #13081
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)