Fix: Increase preview area in style selection dialog to show full citation preview (#13051)#13072
Merged
Merged
Conversation
Member
|
Looks good to me so far. Will try this later today on my mac |
subhramit
reviewed
May 7, 2025
7 tasks
Member
|
As a result of a design decision in #13074, I removed the Modify bibliography title button from the tab, which was causing the CSL preview to shrink, but I am fine with merging this fix as it fixes for JStyles too and a bigger dialog is anyway better. |
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
Siedlerchr
approved these changes
May 7, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
Member
|
Thanks! @lydia-yan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Increase preview area in style selection dialog to show full citation preview (#13051)
Closes #13051
Summary of changes
This PR fixes a UI issue where the preview of citation styles (both Jstyle and CSL) in the OpenOffice style selection dialog was too small, especially on macOS. The preview box height has been increased to ensure full visibility of citation content without requiring vertical scrolling or cutting off lines.
Changes made:
prefHeight) of theVBoxcontaining the preview (cslPreviewBoxandjStylePreviewBox) inStyleSelectDialog.fxml.Screenshots
Before (macOS):
After (macOS):
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)Collaborators
@lydia-yan @yoasaaa @FlyJoanne @brandon-lau0