Improve UX for "Copy to" option with success dialog#13071
Merged
Siedlerchr merged 8 commits intoMay 10, 2025
Conversation
…rary - Add EntryImportHandlerTracker to collect results of asynchronous imports - Modify ImportHandler to use the tracker and defer notifications - Refactor CopyTo to provide aggregated feedback after all entries have been processed - Replace individual notifications with a single contextual summary - Refactor tests to include EntryImportHandlerTracker
…-copy-to-notification-messages-12486
| private final AtomicInteger skipped = new AtomicInteger(0); | ||
|
|
||
| private final int totalEntries; | ||
| private Runnable onFinish; |
There was a problem hiding this comment.
The onFinish callback is nullable, which can lead to NullPointerExceptions if not properly checked. Consider using Optional to handle the absence of a callback.
| } | ||
|
|
||
| private void checkDone(int totalProcessed) { | ||
| if (totalProcessed >= totalEntries && onFinish != null) { |
There was a problem hiding this comment.
Using null checks for control flow is discouraged. Consider using Optional for the onFinish callback to handle its presence or absence more gracefully.
| .onFailure(e -> LOGGER.error("Error in duplicate search")) | ||
| .onFailure(e -> { | ||
| tracker.markSkipped(); | ||
| LOGGER.error("Error in duplicate search", e); |
There was a problem hiding this comment.
The error logging should use logger conversion to log objects directly instead of manual conversion. This improves readability and consistency.
…-copy-to-notification-messages-12486
Siedlerchr
previously approved these changes
May 9, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12486
Added confirmation messages for "Copy to" operations. The messages will be displayed as follows:
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)