Skip to content

Fix: search and groups in sidebar get disabled when no library is opened #12668

Merged
koppor merged 7 commits into
JabRef:mainfrom
palukku:fix-issue-12657
Mar 10, 2025
Merged

Fix: search and groups in sidebar get disabled when no library is opened #12668
koppor merged 7 commits into
JabRef:mainfrom
palukku:fix-issue-12657

Conversation

@palukku

@palukku palukku commented Mar 10, 2025

Copy link
Copy Markdown
Member

Added an observable boolean to disable the search box and groups pane if there is no open database.
Closes #12657.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

image
image

palukku added 5 commits March 10, 2025 10:36
Before the "no content in table" text was very bright now it also looks like disabled.
Realized its sufficient to disable the whole search box / groups pane for every child to become disabled.
@palukku palukku changed the title Fix issue 12657 Fix that search and groups in sidebar get disabled when no library is opened #12657 Mar 10, 2025
koppor
koppor previously approved these changes Mar 10, 2025
koppor
koppor previously approved these changes Mar 10, 2025
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 10, 2025
@koppor koppor requested a review from calixtus March 10, 2025 10:29
@calixtus

Copy link
Copy Markdown
Member

Web search should stay active to allow search for literature even when no library is present, just importing into a preaent library should be disabled. Introduced could be an option to import into new library from Web search.

@koppor

koppor commented Mar 10, 2025

Copy link
Copy Markdown
Member

Introduced could be an option to import into new library from Web search.

This is a follow-up, because currently, this is not possible.

@trag-bot

trag-bot Bot commented Mar 10, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor enabled auto-merge March 10, 2025 14:35
@koppor koppor added this pull request to the merge queue Mar 10, 2025
Merged via the queue into JabRef:main with commit be973cb Mar 10, 2025
@palukku palukku changed the title Fix that search and groups in sidebar get disabled when no library is opened #12657 Fix: search and groups in sidebar get disabled when no library is opened Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable functionality for non-existing library

3 participants