Skip to content

Clean up JabRef resources#12665

Merged
Siedlerchr merged 5 commits into
JabRef:mainfrom
Abdelrahman-358:fix-for-issue-12660
Mar 10, 2025
Merged

Clean up JabRef resources#12665
Siedlerchr merged 5 commits into
JabRef:mainfrom
Abdelrahman-358:fix-for-issue-12660

Conversation

@Abdelrahman-358

@Abdelrahman-358 Abdelrahman-358 commented Mar 9, 2025 •
edited by subhramit
Loading

Copy link
Copy Markdown
Contributor

Replaced Twitter with Mastodon and added LinkedIn in JabRef resources.

Closes #12660

Before
image

After
image

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Abdelrahman-358 Abdelrahman-358 changed the title Fix for issue 12660 Replaced Twitter with Mastodon and added LinkedIn in JabRef resources Fixes #12660 . Mar 9, 2025
@Abdelrahman-358 Abdelrahman-358 changed the title Replaced Twitter with Mastodon and added LinkedIn in JabRef resources Fixes #12660 . Replaced Twitter with Mastodon and added LinkedIn in JabRef resources Fixes . Mar 9, 2025
@Abdelrahman-358 Abdelrahman-358 changed the title Replaced Twitter with Mastodon and added LinkedIn in JabRef resources Fixes . Replaced Twitter with Mastodon and added LinkedIn in JabRef resources . Mar 9, 2025
github-actions[bot]
github-actions Bot reviewed Mar 9, 2025
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Siedlerchr
Siedlerchr previously approved these changes Mar 9, 2025
View reviewed changes
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 9, 2025
@subhramit

subhramit commented Mar 9, 2025

Copy link
Copy Markdown
Member

We still have a twitter handle, right @Siedlerchr https://x.com/JabRef_org

@subhramit subhramit removed this pull request from the merge queue due to a manual request Mar 9, 2025
@subhramit

subhramit commented Mar 9, 2025

Copy link
Copy Markdown
Member

We still have a twitter handle, right @Siedlerchr https://x.com/JabRef_org

@AbdoMostfa2 Can you replace the twitter icon with X's and put this link

subhramit
subhramit requested changes Mar 9, 2025
View reviewed changes

@subhramit subhramit left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above ^

@Abdelrahman-358

Abdelrahman-358 commented Mar 9, 2025

Copy link
Copy Markdown
Contributor Author

@AbdoMostfa2 Can you replace the twitter icon with X's and put this link
Yes, sure! However, X's logo does not exist in Material Design Icons. Should I create a custom logo using JabRefMaterialDesignIcon, or just update the link and name while keeping the previous Twitter logo?

@subhramit

subhramit commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Yes, sure! However, X's logo does not exist in Material Design Icons. Should I create a custom logo using JabRefMaterialDesignIcon, or just update the link and name while keeping the previous Twitter logo?

If you have time to create it, sure! Otherwise for the sake of this PR you can just update the link and keep the old logo.

@JabRef/developers how were the icons for vim and emacs created? Were they all manually designed or is there a shortcut way to use svgs from elsewhere?

Ref. https://devdocs.jabref.org/code-howtos/custom-svg-icons.html

@Siedlerchr

Siedlerchr commented Mar 10, 2025 via email •
edited by calixtus
Loading

Copy link
Copy Markdown
Member

@Abdelrahman-358

Abdelrahman-358 commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

Yes, sure! However, X's logo does not exist in Material Design Icons. Should I create a custom logo using JabRefMaterialDesignIcon, or just update the link and name while keeping the previous Twitter logo?

If you have time to create it, sure! Otherwise for the sake of this PR you can just update the link and keep the old logo.

@JabRef/developers how were the icons for vim and emacs created? Were they all manually designed or is there a shortcut way to use svgs from elsewhere?

Ref. https://devdocs.jabref.org/code-howtos/custom-svg-icons.html

For now, I have just updated the Twitter link. If there is a need to update the icon, I may do it later.

@calixtus

calixtus commented Mar 10, 2025

Copy link
Copy Markdown
Member

Be aware that the new x logo is just a unicode character for a mathematical x.
https://www.popularmechanics.com/technology/apps/a44641211/twitter-x-unicode-symbol/

@Abdelrahman-358

Abdelrahman-358 commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

Be aware that the new x logo is just a unicode character for a mathematical x. https://www.popularmechanics.com/technology/apps/a44641211/twitter-x-unicode-symbol/

Could this be good?
image

@calixtus

calixtus commented Mar 10, 2025

Copy link
Copy Markdown
Member

that does not look like the mathematical x at all. Maybe you will have to create a new icon as described in https://devdocs.jabref.org/code-howtos/custom-svg-icons.html

@subhramit

subhramit commented Mar 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

We do not use Twitter anymore actively. No need for it

Okay then - if we don't use it then it'll be effort for nothing.
For the link - should it be be removed entirely? Or kept (updated to the x one)?

@calixtus

calixtus commented Mar 10, 2025

Copy link
Copy Markdown
Member

No, twitter / x link can be removed completly.

@subhramit subhramit changed the title Replaced Twitter with Mastodon and added LinkedIn in JabRef resources . Clean up JabRef resources Mar 10, 2025
@trag-bot

trag-bot Bot commented Mar 10, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr enabled auto-merge March 10, 2025 09:54
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 10, 2025
Merged via the queue into JabRef:main with commit b2fcdef Mar 10, 2025
@Abdelrahman-358 Abdelrahman-358 deleted the fix-for-issue-12660 branch March 10, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@subhramit subhramit subhramit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up "JabRef resources"

4 participants

@Abdelrahman-358 @subhramit @Siedlerchr @calixtus