Improve TagsField of keywords#12633
Merged
Merged
Conversation
- Can now paste multiple or single keywords without pressing enter Related to JabRef#10984
- implement keyword removing and inserting through drag and drop - show different color for dragged and dropped keywords (may require admin specify another color) - run checkstyle with no error
- implement keyword removing and inserting through drag and drop - show different color for dragged and dropped keywords (may require admin specify another color) - run checkstyle with no error Related to JabRef#10984
… into feat/drag-and-drop
feat: reorder keywords by drag and drop
feat(keywordsEditor): Added paste function
feat(keywords): double click enters edit mode, new keywords are sorted alphabetically if list is sorted
Related to JabRef#10984
Related to JabRef#10984
7 tasks
subhramit
reviewed
Mar 6, 2025
| keywordTagsField.getEditor().setOnKeyPressed(evt -> { | ||
| KeyBindingRepository keyBindingRepository = Injector.instantiateModelOrService(KeyBindingRepository.class); | ||
|
|
||
| if (keyBindingRepository.checkKeyCombinationEquality(KeyBinding.PASTE, evt)) { |
Member
There was a problem hiding this comment.
Please expand the abbreviation "evt"
subhramit
reviewed
Mar 6, 2025
| } else { | ||
| event.setDropCompleted(false); | ||
| } | ||
| draggedKeyword = null; |
Member
There was a problem hiding this comment.
I would prefer using Optional<Keyword> instead of Keyword for draggedKeyword.
- expand abbreviation `evt` into `event` in line 111 - substitute `Keyword` by `Optional<Keyword>` for `draggedKeyword` Related to JabRef#10984
Contributor
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
Related to JabRef#10984
|
@trag-bot didn't find any issues in the code! ✅✨ |
Pull request summary
|
Contributor
Author
|
Hi, I change code according to your reviews. Contact if there's more problem. |
Siedlerchr
approved these changes
Mar 7, 2025
Member
|
Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On paste: If it is possible to add this keyword, directly add it without requiring the user to press Enter
Double click on keyword: remove it and enter edit mode.
Reorder keywords by drag and drop
Alphabetic ordering of keywords. In case the list is already alphabetically ordered, add the new keyword in alphabetical order. Otherwise, add it to the end
Notes
This pull request is a new version of #12632 but solve checkstyle errors and branch name. The old pull request is closed and ignored.
Closes #10984
Mandatory Checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)