Skip to content

Enable drag-and-drop of PDFs into groups Fixes #12540#12626

Merged
Siedlerchr merged 11 commits into
JabRef:mainfrom
Abdelrahman-358:fix-for-issue-12540
Mar 7, 2025
Merged

Enable drag-and-drop of PDFs into groups Fixes #12540#12626
Siedlerchr merged 11 commits into
JabRef:mainfrom
Abdelrahman-358:fix-for-issue-12540

Conversation

@Abdelrahman-358

@Abdelrahman-358 Abdelrahman-358 commented Mar 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Enable drag-and-drop of PDFs into groups Fixes #12540

Before
before
After
after

"Closes #12540".

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

subhramit
subhramit reviewed Mar 6, 2025
View reviewed changes
Comment thread buildres/abbrv.jabref.org

@subhramit subhramit Mar 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the submodule changes as per https://devdocs.jabref.org/code-howtos/faq.html#submodules
(use the alternative method)

@Abdelrahman-358 Abdelrahman-358 Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@trag-bot

trag-bot Bot commented Mar 7, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@trag-bot

trag-bot Bot commented Mar 7, 2025

Copy link
Copy Markdown

Pull request summary

  • Added a "Copy citation (text)" button to the context menu of the preview.
  • Introduced an "Export to clipboard" button in the context menu of the preview.
  • Implemented an integrity check for URLs appearing in titles.
  • Enabled drag-and-drop functionality for PDFs into groups.
  • Modified the acceptableDrop method to allow file drops in addition to existing entry and group drops.
  • Updated the handleOnDragDropped method to process dropped files and import them in the background.
  • Enhanced the handleOnDragOver method to recognize file drops alongside Bib entries.
  • Refactored the GroupTreeView constructor to include new dependencies for file handling and undo management.
  • Added necessary imports for file handling and undo management in the GroupTreeView class.
  • Updated the SidePaneContentFactory to accommodate the new constructor parameters for GroupTreeView.

Siedlerchr
Siedlerchr previously approved these changes Mar 7, 2025
View reviewed changes
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 7, 2025
@Siedlerchr

Siedlerchr commented Mar 7, 2025

Copy link
Copy Markdown
Member

Tested. Works fine

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Mar 7, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 7, 2025
Merged via the queue into JabRef:main with commit bcf2032 Mar 7, 2025
@Abdelrahman-358 Abdelrahman-358 deleted the fix-for-issue-12540 branch March 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@subhramit subhramit Awaiting requested review from subhramit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drag'n'drop of a PDF (from file explorer) to group should add the file

3 participants

@Abdelrahman-358 @Siedlerchr @subhramit