Fix trigger of fetcher tests#12619
Merged
Merged
Conversation
InAnYan
reviewed
Mar 4, 2025
| paths: | ||
| - 'src/main/java/org/jabref/logic/importer/fetcher/**' | ||
| - 'src/test/java/org/jabref/logic/importer/fetcher/**' | ||
| - 'src/main/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporter.java' |
Member
There was a problem hiding this comment.
I was thinking: what about adding whole importer/**? Importers != fetchers?
Member
Author
There was a problem hiding this comment.
- importers work on the local file system
- fetchers work on remoate
- PdfMergeMetaDataImporter is a "hybrid", because it works on the file system, but also uses external sourfces
Aim of having less triggers: Not hitting any rate limit.
Member
Author
There was a problem hiding this comment.
Not sure where to note that down? package-info.java in package org.jabref.logic.importer.fetcher?
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8258 ->
org.jabref.logic.importer.fileformat.pdf.PdfMergeMetadataImporterTestis marked as fetcher test. Thus, fetcher tests should run if a change in this file occurs.Whole thing triggered by #12088 rendering a test not working, but did not show up, because no fetcher tests ran.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)