Add copy preview buttons #12576
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
InAnYan
previously requested changes
Mar 1, 2025
InAnYan
left a comment
Member
There was a problem hiding this comment.
Looks good!
Haven't tested yet. I've proposed some small changes
Siedlerchr
previously approved these changes
Mar 2, 2025
Siedlerchr
approved these changes
Mar 2, 2025
Siedlerchr
approved these changes
Mar 2, 2025
fixed the changelog, rest is okay feature works
Member
|
This PR is wrong for the HTML part. compare <font face="sans-serif"><b>Article</b><a name="Richard_2017"> (Richard_2017)</a>
<BR><BR>Richard, Anna / Meule, Adrian / Friese, Malte / Blechert, Jens
<BR><b>Effects of Chocolate Deprivation on Implicit and Explicit Evaluation of Chocolate in High and Low Trait Chocolate Cravers</b>
<BR>2017-09
<BR><BR><i>Frontiers in Psychology</i> , Vol. 8
<BR>Frontiers Media SA
</font>with <!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
</head>
<body>
Article (Richard_2017)
Richard, Anna / Meule, Adrian / Friese, Malte / Blechert, Jens
Effects of Chocolate Deprivation on Implicit and Explicit Evaluation of Chocolate in High and Low Trait Chocolate Cravers
2017-09
Frontiers in Psychology , Vol. 8
Frontiers Media SA
</body>
</html>I will create a follow-up issue. |
Member
|
I filed #13041 as follow-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12551
This PR adds in the context menu of the preview a copy citation as text button and an export to clipboard button. It also changes the copy preview button to copy citation (html). All buttons have the same functionality as the context menu in the main menu.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)Copy Citation (html)
Copy Citation (text)
Export to clipboard
Export to clipboard dialog