Skip to content

Include PubMed labels in abstract at import (closes #12527)#12545

Merged
Siedlerchr merged 3 commits into
JabRef:mainfrom
ungerts:feature/12527
Feb 23, 2025
Merged

Include PubMed labels in abstract at import (closes #12527)#12545
Siedlerchr merged 3 commits into
JabRef:mainfrom
ungerts:feature/12527

Conversation

@ungerts

@ungerts ungerts commented Feb 23, 2025

Copy link
Copy Markdown
Contributor

During the import process, the labels indicating individual paragraphs within an abstract returned by PubMed/Medline XML are preserved. Closes #12527. Also complexity of some methodes is reduced.

Example

Example

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines. We use OpenRewrite to ensure "modern" Java coding practices. The issues found can be automatically fixed. Please execute the gradle task rewriteRun, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@Siedlerchr Siedlerchr added this pull request to the merge queue Feb 23, 2025
@Siedlerchr

Copy link
Copy Markdown
Member

Thanks a lot for the improvements!

@Siedlerchr

Copy link
Copy Markdown
Member

@ungerts As you seem to have some in-depth knowledge about Pubmed/Medline, maybe you can add your thoughts or perhaps tackle the issue #12532 as well

Merged via the queue into JabRef:main with commit 186f7e4 Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include abstract labels with PubMed MEDLINE xml import

2 participants