Replace general get/put/remove metadata calls with typed versions#1250
Merged
Conversation
| try { | ||
| defaults.put(USER_FILE_DIR_IND_LEGACY, Globals.FILE_FIELD + Globals.DIR_SUFFIX + '-' + get(DEFAULT_OWNER) + '@' + InetAddress.getLocalHost().getHostName()); // Legacy setting name - was a bug: @ not allowed inside BibTeX comment text. Retained for backward comp. | ||
| defaults.put(USER_FILE_DIR_INDIVIDUAL, Globals.FILE_FIELD + Globals.DIR_SUFFIX + '-' + get(DEFAULT_OWNER) + '-' + InetAddress.getLocalHost().getHostName()); // Valid setting name | ||
| return get(DEFAULT_OWNER) + '-' + InetAddress.getLocalHost().getHostName(); |
Contributor
There was a problem hiding this comment.
Why do you remove the user file dir individual default values?
Member
Author
There was a problem hiding this comment.
USER_FILE_DIR_INDIVIDUAL was never a real preference and only used as a key to some other preference, i.e. the code read pref.get(pref.get(USER_FILE_DIR_INDIVIDUAL)) before and now takes the form pref.get(pref.getUser()). Moreover, USER_FILE_DIR_INDIVIDUAL was never set and so stayed at the default value.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed support of legacy user-specific file paths (serialized with a @ symbol). JabRef stopped writing this format over 3 years ago (according to https://sourceforge.net/p/jabref/bugs/1153/).