Add confirmation for 'Copy to' with cross-reference status#12493
Conversation
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
|
|
||
| if (includeCrossReferences) { | ||
| copyEntriesWithCrossRef(selectedEntries, targetDatabaseContext); | ||
| dialogService.notify(Localization.lang("Entry copied successfully, including cross-reference.")); |
There was a problem hiding this comment.
Please change to "entries" and "references".
(Tip - Here is how I, as a newcomer, would gather context - selectedEntries above is a list, and the name is plural as well. The function name also hints at the same. So it cannot be a single entry. I would go one level further and ctrl + click on the function to see what it's doing).
| dialogService.notify(Localization.lang("Entry copied successfully, including cross-reference.")); | ||
| } else { | ||
| copyEntriesWithoutCrossRef(selectedEntries, targetDatabaseContext); | ||
| dialogService.notify(Localization.lang("Entry copied successfully, no cross-reference included.")); |
| Entry\ copied\ successfully,\ including\ cross-reference.=Entry copied successfully, including cross-reference. | ||
| Entry\ copied\ successfully,\ no\ cross-reference\ included.=Entry copied successfully, no cross-reference included. |
There was a problem hiding this comment.
Change accordingly. Also, change the second line to "...without cross-references."
There was a problem hiding this comment.
Thanks for the feedback! I will make sure to read functions carefully next time..
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
fixes #12486
Add confirmation message after using "Copy to" option, also show whether the cross-reference entry was copied or not.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)Copy to with cross-reference included
Copy to with cross-reference excluded