JabRef · koppor · Feb 25, 2025 · Jan 29, 2025 · Jan 30, 2025 · Jan 30, 2025
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added a new CLI that supports txt, csv, and console-based output for consistency in BibTeX entries. [#11984](https://github.com/JabRef/jabref/issues/11984)
 - We added a new dialog for bibliography consistency check. [#11950](https://github.com/JabRef/jabref/issues/11950)
 - We added a feature for copying entries to libraries, available via the context menu, with an option to include cross-references. [#12374](https://github.com/JabRef/jabref/pull/12374)
+- We added an integrity check if a URL appears in a title. [#12354](https://github.com/JabRef/jabref/issues/12354)
 
 ### Changed
 

diff --git a/src/main/java/org/jabref/logic/integrity/FieldCheckers.java b/src/main/java/org/jabref/logic/integrity/FieldCheckers.java
@@ -48,6 +48,9 @@ private static Multimap<Field, ValueChecker> getAllMap(BibDatabaseContext databa
         fieldCheckers.put(StandardField.KEY, new ValidCitationKeyChecker());
         fieldCheckers.put(InternalField.KEY_FIELD, new ValidCitationKeyChecker());
 
+        fieldCheckers.put(StandardField.TITLE, new NoURLChecker());
+        fieldCheckers.put(StandardField.BOOKTITLE, new NoURLChecker());
+
         if (databaseContext.isBiblatexMode()) {
             fieldCheckers.put(StandardField.DATE, new DateChecker());
             fieldCheckers.put(StandardField.URLDATE, new DateChecker());

diff --git a/src/main/java/org/jabref/logic/integrity/NoURLChecker.java b/src/main/java/org/jabref/logic/integrity/NoURLChecker.java
@@ -0,0 +1,22 @@
+package org.jabref.logic.integrity;
+
+import java.util.Optional;
+
+import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.util.URLUtil;
+import org.jabref.model.strings.StringUtil;
+
+public class NoURLChecker implements ValueChecker {
+
+    public Optional<String> checkValue(String value) {
+        if (StringUtil.isBlank(value)) {
+            return Optional.empty();
+        }
+
+        if (URLUtil.URL_PATTERN.matcher(value).find()) {
+            return Optional.of(Localization.lang("contains a URL"));
+        }
+
+        return Optional.empty();
+    }
+}
diff --git a/src/main/java/org/jabref/logic/util/URLUtil.java b/src/main/java/org/jabref/logic/util/URLUtil.java
@@ -7,13 +7,22 @@
 import java.net.URLDecoder;
 import java.nio.charset.StandardCharsets;
 import java.util.Objects;
+import java.util.regex.Pattern;
 
 /**
  * URL utilities for URLs in the JabRef logic.
  * <p>
  * For GUI-oriented URL utilities see {@link org.jabref.gui.fieldeditors.URLUtil}.
  */
 public class URLUtil {
+
+    private static final String URL_REGEX = "(?i)\\b((?:https?|ftp)://[^\\s]+)";
+
+    /**
+     * Pattern matches a string containing a URL with a protocol
+     */
+    public static final Pattern URL_PATTERN = Pattern.compile(URL_REGEX, Pattern.CASE_INSENSITIVE);
+
     private static final String URL_EXP = "^(https?|ftp)://.+";
     // Detect Google search URL
     private static final String GOOGLE_SEARCH_EXP = "^https?://(?:www\\.)?google\\.[\\.a-z]+?/url.*";

diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
@@ -1626,16 +1626,18 @@ JabRef\ would\ not\ have\ been\ possible\ without\ the\ help\ of\ our\ contribut
 
 HTML\ encoded\ character\ found=HTML encoded character found
 booktitle\ ends\ with\ 'conference\ on'=booktitle ends with 'conference on'
+contains\ a\ URL=contains a URL
 
 incorrect\ control\ digit=incorrect control digit
 incorrect\ format=incorrect format
+
 Copied\ version\ to\ clipboard=Copied version to clipboard
 
 Citation\ key=Citation key
 Message=Message
 
-
 MathSciNet\ Review=MathSciNet Review
+
 Reset\ all=Reset all
 
 Decryption\ not\ supported.=Decryption not supported.
@@ -2854,6 +2856,7 @@ Include=Include
 Exclude=Exclude
 Include\ or\ exclude\ cross-referenced\ entries=Include or exclude cross-referenced entries
 Would\ you\ like\ to\ include\ cross-reference\ entries\ in\ the\ current\ operation?=Would you like to include cross-reference entries in the current operation?
+
 Entries\ copied\ successfully,\ including\ cross-references.=Entries copied successfully, including cross-references.
 Entries\ copied\ successfully,\ without\ cross-references.=Entries copied successfully, without cross-references.
 

diff --git a/src/test/java/org/jabref/logic/integrity/NoURLCheckerTest.java b/src/test/java/org/jabref/logic/integrity/NoURLCheckerTest.java
@@ -0,0 +1,30 @@
+package org.jabref.logic.integrity;
+
+import java.util.Optional;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+public class NoURLCheckerTest {
+
+    private final NoURLChecker checker = new NoURLChecker();
+
+    @ParameterizedTest(name = "{index}. Title: \"{0}\"")
+    @CsvSource({
+            "Proceedings of the https://example.com/conference",
+            "Find more at http://mywebsite.org/article",
+            "Visit ftp://files.example.com/download",
+    })
+    void fieldShouldRaiseWarningForFullURLs(String title) {
+        assertNotEquals(Optional.empty(), checker.checkValue(title));
+    }
+
+    @Test
+    void fieldShouldAcceptURLWithoutProtocol() {
+        assertEquals(Optional.empty(), checker.checkValue("Applying Trip@dvice Recommendation Technology to www.visiteurope.com"));
+    }
+}