Skip to content

Fixes #1234 Trigger entry update explicitly#1243

Merged
matthiasgeiger merged 3 commits into
masterfrom
fix-1234
Apr 20, 2016
Merged

Fixes #1234 Trigger entry update explicitly#1243
matthiasgeiger merged 3 commits into
masterfrom
fix-1234

Conversation

@stefan-kolb

Copy link
Copy Markdown
Member

I'm not quite sure if this fixes all issues. The real problem ist the update mechanism of the StoreFieldAction imho. Our GUI state is so inconsistent...

@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 19, 2016
@oscargus

Copy link
Copy Markdown
Contributor

Worth a try! 👍

There are probably more field components where something similar is required. I tested looking up DOI and switching to source view and it wasn't updated (not with your fix though), so probably we should add it consistently if it is the solution.

@tobiasdiez

Copy link
Copy Markdown
Member

Does setting the doi directly for the entry also update the display? I.e. does entryEditor.getEntry().setField("doi", result) instead of JTextComponent.setText works?

@stefan-kolb

Copy link
Copy Markdown
Member Author

Yeah, looks like this works too.

@matthiasgeiger

Copy link
Copy Markdown
Member

👍

@matthiasgeiger matthiasgeiger merged commit ea64bba into master Apr 20, 2016
@stefan-kolb stefan-kolb deleted the fix-1234 branch April 26, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants