Skip to content

Update icons#12408

Merged
Siedlerchr merged 3 commits into
JabRef:mainfrom
InAnYan:fix-7771
Jan 25, 2025
Merged

Update icons#12408
Siedlerchr merged 3 commits into
JabRef:mainfrom
InAnYan:fix-7771

Conversation

@InAnYan

@InAnYan InAnYan commented Jan 21, 2025

Copy link
Copy Markdown
Member

Closes #7771.

Replaced icon for:

  • Windows
  • Linux

Though, I see 2 problems:

  1. Should .ico be more complex? Contain several versions of image in different sizes?
  2. Where are the original SVG sources for the macOs icon?

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr

Siedlerchr commented Jan 21, 2025

Copy link
Copy Markdown
Member

For mac i used https://icon.kitchen/i/H4sIAAAAAAAAAx1NWw6DMAy7S%2FbLCfjlCvxN0xSatKuWEtTHJoS4Oyn5cGTHsQ%2F4oTQuMB5AmL%2FzhxPD6FEKD%2BDDJHHDXPu5sC0g9tikwgDR6WoCEr1FHdZo9Ow%2F875ZBMSEgc23hElFsykPf093JaUmvfYJuFLWSD1Ri%2BGfF8OEztjrvAD4oKT7oQAAAA%3D%3D
and simply uploaded the jabref svg file and set background to white
It directly generated me the icns files

@Siedlerchr

Siedlerchr commented Jan 21, 2025

Copy link
Copy Markdown
Member

https://docs.oracle.com/en/java/javase/23/jpackage/override-jpackage-resources.html#GUID-1B718F8B-B68D-4D46-B1DB-003D7729AAB6
but does not say anything about size

@InAnYan

InAnYan commented Jan 22, 2025

Copy link
Copy Markdown
Member Author

@Siedlerchr, IDK why, but I don't have logo at https://icon.kitchen/i/H4sIAAAAAAAAAx1NWw6DMAy7S%2FbLCfjlCvxN0xSatKuWEtTHJoS4Oyn5cGTHsQ%2F4oTQuMB5AmL%2FzhxPD6FEKD%2BDDJHHDXPu5sC0g9tikwgDR6WoCEr1FHdZo9Ow%2F875ZBMSEgc23hElFsykPf093JaUmvfYJuFLWSD1Ri%2BGfF8OEztjrvAD4oKT7oQAAAA%3D%3D, everything is white

image

@Siedlerchr

Siedlerchr commented Jan 22, 2025

Copy link
Copy Markdown
Member

Ah yes it didn't store the uploaded jabref svg

without-bg.svg.zip

without-bg

@InAnYan

InAnYan commented Jan 23, 2025

Copy link
Copy Markdown
Member Author

It does not contain that blue square. Or I shouldn't add it to src/main/resources/icons?

@Siedlerchr

Siedlerchr commented Jan 23, 2025

Copy link
Copy Markdown
Member

We can only specify one icon https://bugs.openjdk.org/browse/JDK-8241714
But there is also a converter for icns to ico https://www.coolutils.com/online/ICNS-to-ICO#

@Siedlerchr

Siedlerchr commented Jan 23, 2025

Copy link
Copy Markdown
Member

It does not contain that blue square. Or I shouldn't add it to src/main/resources/icons?

Sorry, but I don't understand what you mean?

@InAnYan

InAnYan commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

image

Sorry, should jabref.svg and JabRef-icon-64.png be replaced with a new icon like in jabref.ico?

OMG: I literally wrote blue square 😆. I meant white square

@InAnYan

InAnYan commented Jan 23, 2025

Copy link
Copy Markdown
Member Author

BTW, from #7771 (comment)

I think Windows icon should be replaced too? (Because it also has problems #7771 (comment))

@Siedlerchr

Siedlerchr commented Jan 25, 2025

Copy link
Copy Markdown
Member

I checked the build gradle.

  1. Windows uses the ico => We should place it all in buildres to have a common folder where everything for the installer is located
  2. linux uses the jabref-icon-64 png => We should make a copy of that and use the white square as background
  3. Mac uses the icns file

The Jabref-icon... png are also used internally for the title bar (they are applied to the stage)
grafik

jabref svg should be kept as is for reference purposes, it's not used anywhere.

@InAnYan

InAnYan commented Jan 25, 2025

Copy link
Copy Markdown
Member Author

Great. Then it seems that I just need to replace icon for Linux and Windows with macOs icon -- which I already did 😃

Ready to merge?

@Siedlerchr Siedlerchr enabled auto-merge January 25, 2025 12:36
@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 25, 2025
Merged via the queue into JabRef:main with commit 5046e06 Jan 25, 2025
@Siedlerchr Siedlerchr deleted the fix-7771 branch January 25, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App Icon is too dark

2 participants

@InAnYan @Siedlerchr