Remove irrelevant menu options for unsaved files#12162
Closed
kjswaruph wants to merge 1 commit into
Closed
Conversation
Member
|
But they need to be there for a saved library! |
Member
|
This does not fix the issue. First, we want to disable the relevant menu items not remove them. Second, the menu items should be kept enabled for saved libraries. To tackle this, we need to figure a way to distinguish saved from unsaved libraries (hint: a saved library has a path in the filesystem). Then we need to bind (please read about JavaFX binding if you haven't already) that property to the enabled/disabled status of the show in folder and open console menu items. |
Author
|
sorry for that i am now trying to only disable not remove the menu options. |
Member
|
Some code hints on disabling is available at #11941. |
7 tasks
Member
|
Superseded by #12199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Whenever a new library is created which is not saved yet displays The "Reveal in file explorer" and "Open terminal here" options which are uneccesary.
Changes: Disabled the "Reveal in file explorer" and "Open terminal here" options by removing factory.createMenuItem() for respective options
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)