find the title from second page#12157
Conversation
find the title from second page
| @@ -232,7 +232,7 @@ public TitleExtractorByFontSize() { | |||
|
|
|||
| public String getTitleFromFirstPage(PDDocument document) throws IOException { | |||
There was a problem hiding this comment.
The method name does not match the content of the method any more.
fix method name
|
I believe we need to find or create a test file to move forward here. Maybe we can ask the university if they can provide an mit licensed test file? |
add a unit test file with a test cover page
|
Test PDF not OK - the title page is OK, but the subsequent PDF not
You can use for example following paper: I bought an Acrobat Professional X for 10€ some years ago. - I think, other PDF tools such as PDFSam also work to create a PDF. |
koppor
left a comment
There was a problem hiding this comment.
Test PDF needs to be updated.
I love consistency - and the title page should somehow match the PDF attached. You can also create a new PDF based on src\test\resources\pdfs\IEEE)
change unit test cover page file
koppor
left a comment
There was a problem hiding this comment.
I love consistency - and the title page should somehow match the PDF attached. You can also create a new PDF based on
src\test\resources\pdfs\IEEE)
The current version has following data:
Page 1:
- Two Authors: "Test Author" asnd "Author Test"
- Titel: "A Test Title."
Page 2:
- One author: "First Author"
- Title: "JabRef Example for Reference Parsing"
Please make this consistent. Make the first page matchting the second page. Change "Test Author, Author Test" to "First Author". Change "A Test Title." to "JabRef Example for Reference Parsing"
fix the pdf file with consistency cover
leaf-soba
left a comment
There was a problem hiding this comment.
fix the pdf file with consistent cover
|
I think this needed a changelog entry? |
Good point! Can you create one? 😅 |
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)