Add SSRN urls to CompositeIdFetcher#12021
Merged
Merged
Conversation
JabRef#12009 started using CompositeIdFetcher for fetching logic. This removes the dead code functions in ImportHandler
Contributor
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
koppor
requested changes
Oct 19, 2024
koppor
left a comment
Member
There was a problem hiding this comment.
Minor comments. All in all, looks good!
koppor
approved these changes
Oct 20, 2024
Member
|
@trickypr Thank you for the work! Maybe, you can tackle another issue, too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows importing (e.g. via pasting) of both short and long SSRN URLs via their associated DOI.
This also removes some dead code that was not cleaned up in #12009.
Closes #11687
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)