Skip to content

Add ADR for "Localized Preferences"revisited#11988

Merged
koppor merged 6 commits into
mainfrom
localized-defaults
Feb 16, 2025
Merged

Add ADR for "Localized Preferences"revisited#11988
koppor merged 6 commits into
mainfrom
localized-defaults

Conversation

@calixtus

Copy link
Copy Markdown
Member

refs #8304

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You modified Markdown (*.md) files and did not meet JabRef's rules for consistently formatted Markdown files.
To ensure consistent styling, we have markdown-lint in place.
Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".

@koppor

koppor commented Oct 16, 2024

Copy link
Copy Markdown
Member

We should take the time to create a good ADR of it. We should follow the template https://github.com/adr/madr/blob/develop/template/adr-template-bare.md

  1. Have the option titles only in the list of "Considered Options"
  2. Add section "Pros and Cons of the Options"
  3. Create subsecton for each option
  4. Move explaning text to each option
  5. Add examples.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You modified Markdown (*.md) files and did not meet JabRef's rules for consistently formatted Markdown files.
To ensure consistent styling, we have markdown-lint in place.
Markdown lint's rules help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".

@github-actions

Copy link
Copy Markdown
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11988/merge.

@koppor koppor marked this pull request as ready for review February 16, 2025 21:14
@koppor koppor enabled auto-merge February 16, 2025 21:14
@koppor koppor changed the title [WIP] Localized Preferences revisited Add ADR for "Localized Preferences"revisited Feb 16, 2025
@koppor koppor disabled auto-merge February 16, 2025 21:20
@koppor koppor merged commit 23cf529 into main Feb 16, 2025
@koppor koppor deleted the localized-defaults branch February 16, 2025 21:20
@github-actions

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants