Ask for enable indexing when clicking fulltext search#11854
Conversation
koppor
left a comment
There was a problem hiding this comment.
Small comment/question inside.
Can you look into following, too?
If I disable fulltext search in the prefernces (1), it should also be disabled in the search bar (2).
| boolean enableFulltextSearch = dialogService.showConfirmationDialogAndWait(Localization.lang("Fulltext search"), Localization.lang("Fulltext search requires the setting 'Automatically index all linked files for fulltext search' to be enabled. Do you want to enable indexing now?"), Localization.lang("Enable indexing"), Localization.lang("Keep disabled")); | ||
|
|
||
| LibraryTab libraryTab = tabContainer.getCurrentLibraryTab(); | ||
| if (libraryTab != null && enableFulltextSearch) { |
There was a problem hiding this comment.
We should try to disable the button if no library is active. Refs #11837.
Follow-up I would say.
There was a problem hiding this comment.
If we disable it, the new dialog would never come up
There was a problem hiding this comment.
Search is disabled if libray is not active
There was a problem hiding this comment.
Intellij suggested that because library tab is nullable.. (reduce warnings in the code=.
There was a problem hiding this comment.
If we disable it, the new dialog would never come up
The button should be disabled when preferences are off. The dialog will appear if the preferences are disabled and clicks to enable the button. If accepted to enable indexing, the button and preferences should both be enabled; otherwise, both should remain disabled.
There was a problem hiding this comment.
If we disable it, the new dialog would never come up
The button should be disabled when preferences are off. The dialog will appear if the preferences are disabled and clicks to enable the button. If accepted to enable indexing, the button and preferences should both be enabled; otherwise, both should remain disabled.
I understand "clicks to enable the button" as a "click" int he preference.
The thing Christoph implemented was the intention of the whole thing. If we did as you described, we would not implement #9491 (comment).
There was a problem hiding this comment.
I understand "clicks to enable the button" as a "click" int he preference.
The toggle button in the search bar.
There was a problem hiding this comment.
please test the latest changes should be okay now
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I am so sorry, but if I press "Keep disabled", the popup appears again - and again - and again. |
Co-authored-by: Loay Ghreeb <loayahmed655@gmail.com>
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
fixes #9491 (comment)
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)