Skip to content

Improve performance with duplicate check on paste#11843

Merged
Siedlerchr merged 3 commits into
mainfrom
performanceBackgroundThread
Sep 28, 2024
Merged

Improve performance with duplicate check on paste#11843
Siedlerchr merged 3 commits into
mainfrom
performanceBackgroundThread

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Sep 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Run duplicate check on background thread

In 90% cases better performance, except if you have plenty of duplicates (UI dialog is shown then)

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/574

Side effect, UI might freeze if you copy a large number of entries because of respawning the duplicate entry dialog. Not happy about it,

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 28, 2024
@LoayGhreeb

LoayGhreeb commented Sep 28, 2024

Copy link
Copy Markdown
Member

Does this also cover import entries from web searches and "Import into current library" in the File menu?

@Siedlerchr

Siedlerchr commented Sep 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Yes, should be at least for the Web search, that uses the ImportHandler, for the import into current file I am not sure

@github-actions

github-actions Bot commented Sep 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 28, 2024
Merged via the queue into main with commit 538f0ee Sep 28, 2024
@Siedlerchr Siedlerchr deleted the performanceBackgroundThread branch September 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LoayGhreeb LoayGhreeb LoayGhreeb approved these changes

+1 more reviewer

@leaf-soba leaf-soba leaf-soba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @LoayGhreeb @leaf-soba