Skip to content

Add uses directive#11761

Merged
Siedlerchr merged 2 commits into
mainfrom
fix-ai-uses
Sep 15, 2024
Merged

Add uses directive#11761
Siedlerchr merged 2 commits into
mainfrom
fix-ai-uses

Conversation

@koppor

@koppor koppor commented Sep 15, 2024

Copy link
Copy Markdown
Member

Reported by @Siedlerchr

e java.lang.Exception: java.util.ServiceConfigurationError: ai.djl.repository.zoo.ZooProvider: module org.jabref.merged.module does not declare `uses`
	at org.jabref@5.16.30482/org.jabref.gui.util.uitaskexecutor.converttoexception(uitaskexecutor.java:215)
...
Caused by: java.util.ServiceConfigurationError: ai.djl.repository.zoo.ZooProvider: module org.jabref.merged.module does not declare `uses`
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor requested a review from Siedlerchr September 15, 2024 09:28
@Siedlerchr

Siedlerchr commented Sep 15, 2024

Copy link
Copy Markdown
Member

This is for merged module, neecs to be adjusted in the gradle file

@koppor

koppor commented Sep 15, 2024

Copy link
Copy Markdown
Member Author

This is for merged module, neecs to be adjusted in the gradle file

In addition I guess...

@Siedlerchr Siedlerchr mentioned this pull request Sep 15, 2024
Open
@github-actions

github-actions Bot commented Sep 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 15, 2024
Merged via the queue into main with commit 86874f4 Sep 15, 2024
@Siedlerchr Siedlerchr deleted the fix-ai-uses branch September 15, 2024 13:03
@koppor

koppor commented Sep 15, 2024

Copy link
Copy Markdown
Member Author

@InAnYan Check the diff. Interesting learning about Java modules...

@Siedlerchr

Siedlerchr commented Sep 15, 2024

Copy link
Copy Markdown
Member

The issues arose because the djl library is not modularized properly, so it needs to be put in the merged module ("merged module") and as it uses service loaders, we need to specify the implementations as well

@koppor

koppor commented Sep 15, 2024

Copy link
Copy Markdown
Member Author

The issues arose because the djl library is not modularized properly, so it needs to be put in the merged module ("merged module") and as it uses service loaders, we need to specify the implementations as well

Is there already an issue at that repo @InAnYan ?

@Siedlerchr

Siedlerchr commented Sep 15, 2024

Copy link
Copy Markdown
Member

deepjavalibrary/djl#3473

@InAnYan

InAnYan commented Sep 15, 2024

Copy link
Copy Markdown
Member

Oh, I see.

Great that you worked it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koppor @Siedlerchr @InAnYan