Skip to content

Fix: Auto-sync bibliography for JStyle#11690

Merged
Siedlerchr merged 6 commits into
mainfrom
subhramit-ooPanel
Sep 1, 2024
Merged

Fix: Auto-sync bibliography for JStyle#11690
Siedlerchr merged 6 commits into
mainfrom
subhramit-ooPanel

Conversation

@subhramit

@subhramit subhramit commented Aug 31, 2024

Copy link
Copy Markdown
Member

Closes #11684

Cause of issue: See removed comment in (old) line 71 of OOBibBase.java in changed files. boolean refreshBibliographyDuringSyncWhenCiting was always set to false, which rendered the feature non-functional.

  • This is now set properly at the time of citing with JStyles, and the overwrite to false has been removed.
  • Some miscellaneous refactoring

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@subhramit subhramit changed the title Fix: Sync bibliography for JStyle Fix: Auto-sync bibliography for JStyle Sep 1, 2024
@subhramit subhramit requested a review from ThiloteE September 1, 2024 13:15
Comment thread CHANGELOG.md Outdated
@github-actions

github-actions Bot commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 1, 2024
Merged via the queue into main with commit c6ee597 Sep 1, 2024
@Siedlerchr Siedlerchr deleted the subhramit-ooPanel branch September 1, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Automatically sync bibliography when inserting citations" does not work with JStyles

3 participants