Skip to content

Highlight search bar on wrong syntax#11658

Merged
Siedlerchr merged 3 commits into
mainfrom
illegal-search
Aug 21, 2024
Merged

Highlight search bar on wrong syntax#11658
Siedlerchr merged 3 commits into
mainfrom
illegal-search

Conversation

@LoayGhreeb

Copy link
Copy Markdown
Member

Closes LoayGhreeb#11.

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@LoayGhreeb LoayGhreeb added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers component: search labels Aug 20, 2024
koppor
koppor previously requested changes Aug 21, 2024

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good. Please add a CHANGELOG.md entry.

@LoayGhreeb LoayGhreeb requested a review from koppor August 21, 2024 04:12
@github-actions

github-actions Bot commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr enabled auto-merge August 21, 2024 04:38
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit f4e87e5 Aug 21, 2024
@Siedlerchr Siedlerchr deleted the illegal-search branch August 21, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: search status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong syntax should be highlighted more explicitly

3 participants