Skip to content

Upgrade to StAX parsing for CSL style titles#11604

Merged
Siedlerchr merged 8 commits into
JabRef:mainfrom
subhramit:csl-title-stax-2
Aug 11, 2024
Merged

Upgrade to StAX parsing for CSL style titles#11604
Siedlerchr merged 8 commits into
JabRef:mainfrom
subhramit:csl-title-stax-2

Conversation

@subhramit

@subhramit subhramit commented Aug 10, 2024

Copy link
Copy Markdown
Member

[Subsidiary PR for the GSoC '24 CSL4LibreOffice Project]

Upgrade parser of CSL style titles from DOM to StAX

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@subhramit subhramit requested a review from koppor August 10, 2024 16:23
@subhramit subhramit changed the title Upgrade to StAX parsing of CSL style titles Upgrade to StAX parsing for CSL style titles Aug 10, 2024
Comment thread CHANGELOG.md Outdated
@Siedlerchr

Copy link
Copy Markdown
Member

lgtm

Siedlerchr
Siedlerchr previously approved these changes Aug 10, 2024
@Siedlerchr

Copy link
Copy Markdown
Member

please reset the submodules...

@subhramit

Copy link
Copy Markdown
Member Author

please reset the submodules...

done

@subhramit subhramit added this to the 6.0-alpha milestone Aug 11, 2024
@Siedlerchr Siedlerchr enabled auto-merge August 11, 2024 15:04
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 11, 2024
@Siedlerchr

Copy link
Copy Markdown
Member

in your next PR cou can also add a unit test for this

Merged via the queue into JabRef:main with commit c3a21ec Aug 11, 2024
@Siedlerchr Siedlerchr deleted the csl-title-stax-2 branch August 11, 2024 15:13
@subhramit subhramit mentioned this pull request Aug 11, 2024
6 tasks
@subhramit

Copy link
Copy Markdown
Member Author

in your next PR cou can also add a unit test for this

will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants