Make CSL Citation Adapter non-static#11535
Merged
Merged
Conversation
6 tasks
Siedlerchr
reviewed
Jul 28, 2024
| private static final BibEntryTypesManager BIB_ENTRY_TYPES_MANAGER = new BibEntryTypesManager(); | ||
| private static final CitationStyleOutputFormat FORMAT = CitationStyleOutputFormat.HTML; | ||
| private final CitationStyleOutputFormat format = CitationStyleOutputFormat.HTML; | ||
| private final BibEntryTypesManager bibEntryTypesManager = new BibEntryTypesManager(); |
Member
There was a problem hiding this comment.
Use the already existing instance either by BibEntryTypesManager entryTypesManager = Injector.instantiateModelOrService(BibEntryTypesManager.class);
or try to pass it down via constructor
Member
Author
There was a problem hiding this comment.
Done. Went with the latter.
Member
Author
|
Yay fixed submodules myself this time :) |
Member
Author
|
@Siedlerchr Any more changes needed, Chris? Or can this be merged? |
Siedlerchr
approved these changes
Jul 30, 2024
koppor
requested changes
Jul 30, 2024
| * Context: The HTML produced by CitationStyleGenerator.generateCitation(...) is not directly (completely) parsable by OOTextIntoOO.write(...) | ||
| * For more details, read the documentation of the write(...) method in the {@link OOTextIntoOO} class. | ||
| * Additional information: https://devdocs.jabref.org/code-howtos/openoffice/code-reorganization.html. | ||
| * Additional information: <a href="https://devdocs.jabref.org/code-howtos/openoffice/code-reorganization.html">...</a>. |
Member
There was a problem hiding this comment.
This is wrong. Either repeat the link inside the a tag or use "additional information" instead of ...
Member
Author
There was a problem hiding this comment.
Should I make a separate PR or club it with PR-C of my project?
I accepted IntelliJ's suggestion blindly, forgetting how html hrefs work🤦🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making CSL Citation Adapter non-static
Follow-up to #11521
CSLCitationOOAdapter.java, we are making a small architectural change to make it's methods non-static. The static nature happened to be unnecessary, and was a result of trying to use dependencies in some way or the other to get the initial implementation of the adapter working.transformHtmlmethod.Mandatory checks
Change inCHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Tests created for changes (if applicable)Screenshots added in PR description (for UI changes)